Change in vdsm[master]: vdsm: Added pep8 and pyflakes submodules to vdsm source tree

Candace Sheremeta has uploaded a new change for review.

Change subject: vdsm: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................

vdsm: Added pep8 and pyflakes submodules to vdsm source tree

Pep8 submodule from: https://github.com/jcrocholl/pep8
Pyflakes submodule from: https://github.com/pyflakes/pyflakes/

Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Signed-off-by: Candace Sheremeta <cshereme(a)redhat.com&gt;
---
A .gitmodules
A pep8
A pyflakes
3 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/37134/1

diff --git a/.gitmodules b/.gitmodules
new file mode 100644
index 0000000..2711159
--- /dev/null
+++ b/.gitmodules
@@ -0,0 +1,6 @@
+[submodule "pep8"]
+	path = pep8
+	url = https://github.com/jcrocholl/pep8
+[submodule "pyflakes"]
+	path = pyflakes
+	url = https://github.com/pyflakes/pyflakes/
diff --git a/pep8 b/pep8
new file mode 160000
index 0000000..e57e293
--- /dev/null
+++ b/pep8
+Subproject commit e57e293db47b79f757a6a88138cac53dfc913f93
diff --git a/pyflakes b/pyflakes
new file mode 160000
index 0000000..8dd58c9
--- /dev/null
+++ b/pyflakes
+Subproject commit 8dd58c955cda639ae9155fd42b3c69eca47f5a6c


-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: vdsm: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

automation(a)ovirt.org has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15269/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15100/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14312/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15278/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15109/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14321/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Added these submodules to make the build of vdsm slightly smoother,
Line 10: as pep8 and pyflakes will not have to be manually installed any longer.
Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8
Line 12: Pyflakes submodule from: https://github.com/pyflakes/pyflakes/
Please add

 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182088

do you plan to make `make check` use the utilities from the submodules? (I think you
should)
Line 13: 
Line 14: Change-Id: I2248ad929b49684d41a40e944c907298deec4daa


-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-01-20 07:46:20 -0500
Line 4: Commit:     Candace Sheremeta <cshereme(a)redhat.com&gt;
Line 5: CommitDate: 2015-01-20 12:59:40 -0500
Line 6: 
Line 7: packaging: Added pep8 and pyflakes submodules to vdsm source tree
I think we should switch to flake8 which is a nice wrapper for pyflake+pep8 and instead of
using submodules we could use virtualenv (maybe using tox).

That is obviously a larger project than adding two submodules and requires some research
but overall it seems a better and more standard solution.
Line 8: 
Line 9: Added these submodules to make the build of vdsm slightly smoother,
Line 10: as pep8 and pyflakes will not have to be manually installed any longer.
Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8


-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

Adam Litke has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-01-20 07:46:20 -0500
Line 4: Commit:     Candace Sheremeta <cshereme(a)redhat.com&gt;
Line 5: CommitDate: 2015-01-20 12:59:40 -0500
Line 6: 
Line 7: packaging: Added pep8 and pyflakes submodules to vdsm source tree
>  I think we should switch to flake8 which is a nice wrapper for
> pyflake+pep8 
Hmm, I actually think the sub-modules are more standard.  Libvirt and
qemu are both doing this with gnulib and it has been working well for a long time.
Line 8: 
Line 9: Added these submodules to make the build of vdsm slightly smoother,
Line 10: as pep8 and pyflakes will not have to be manually installed any longer.
Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8


-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-01-20 07:46:20 -0500
Line 4: Commit:     Candace Sheremeta <cshereme(a)redhat.com&gt;
Line 5: CommitDate: 2015-01-20 12:59:40 -0500
Line 6: 
Line 7: packaging: Added pep8 and pyflakes submodules to vdsm source tree
>  Hmm, I actually think the sub-modules are more standard.  Libvirt and
> qemu  
Because there's no standard tool in C for that. The pythonic way (e.g.
openstack) is with tox/virtualenv. It's the same for other languages as Go, Ruby,
etc.

Moreover in C you don't need to test different runtimes, while in python/ruby you have
to take in account that as well (py27, py34)... which is something that tox automates very
well.

We don't have to tackle the entire thing in one patch (e.g. tox), but at least move
into that direction.
Line 8: 
Line 9: Added these submodules to make the build of vdsm slightly smoother,
Line 10: as pep8 and pyflakes will not have to be manually installed any longer.
Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8


-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

Candace Sheremeta has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

I've looked into tox / virtualenv. I'm not familiar with it, but trying to get up
to speed.

If tox / virtualenv is the more pythonic way of doing it, then I think I lean towards
that. From the doc: "virtualenv creates a folder which contains all the necessary
executables to use the packages that a Python project would need." Sounds like
exactly what we're trying to achieve.

Federico, can you point us at the OpenStack code that uses it?

Abandoning this patch. Thanks!

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

Candace Sheremeta has abandoned this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Abandoned

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

automation(a)ovirt.org has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No