Change in vdsm[master]: Related to BZ#845020 - Diffferentiate bad specification from...

Eduardo has uploaded a new change for review.

Change subject: Related to BZ#845020 - Diffferentiate bad specification from not found.
......................................................................

Related to BZ#845020 - Diffferentiate bad specification from not found.

Already agreed that _devices should be a dict instead a list.

Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
---
M vdsm/libvirtvm.py
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/7366/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 3b7cfc5..7ad5884 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1627,6 +1627,11 @@
                 if ((device.domainID, device.imageID,
                         device.volumeID) == tgetDrv):
                     return device
+            else:
+                self.log.warning("drive dom: %s, img: %s, vol: %s is not in"
+                                 "vm: %s _devices",
drive["domainID"], 
+                                 drive["imageID"], drive["volumeID"],
self.id)
+                return None
 
         elif drive.has_key("GUID"):
             for device in self._devices[vm.DISK_DEVICES][:]:
@@ -1634,6 +1639,10 @@
                     continue
                 if device.GUID == drive["GUID"]:
                     return device
+            else:
+                self.log.warning("GUID: %s not found in vm: %s _devices",
+                                 drive["GUID"], self.id)
+                return None
 
         elif drive.has_key("UUID"):
             for device in self._devices[vm.DISK_DEVICES][:]:
@@ -1641,8 +1650,13 @@
                     continue
                 if device.UUID == drive["UUID"]:
                     return device
+            else:
+                self.log.warning("UUID: %s not found in vm: %s _devices",
+                                 drive["UUID"], self.id)
+                return None
 
-        return None
+        else:
+            raise ValueError("drive specification unknown %s" % drive)
 
     def snapshot(self, snapDrives):
         """Live snapshot command"""


--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

Itamar Heim has abandoned this change.

Change subject: Related to BZ#845020 - Catch bad VM drive specification.
......................................................................


Abandoned

no reply - abandoning - please restore if still relevant

-- 
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

Gal Hammer has posted comments on this change.

Change subject: Related to BZ#845020 - Catch bad VM drive specification.
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

Ayal Baron has posted comments on this change.

Change subject: Related to BZ#845020 - Catch bad VM drive specification.
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Related to BZ#845020 - Catch bad VM drive specification.
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/759/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Ayal Baron has posted comments on this change.

Change subject: Related to BZ#845020 - Diffferentiate bad specification from not found.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2012-08-21 11:54:07 +0300
Line 4: Commit:     Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Line 5: CommitDate: 2012-08-21 11:54:07 +0300
Line 6: 
Line 7: Related to BZ#845020 - Diffferentiate bad specification from not found.
s/fff/ff/
bad specification of what? no point for bug title here, rather put the crux of the issue.
Line 8: 
Line 9: Already agreed that _devices should be a dict instead a list.
Line 10: 
Line 11: Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36


Line 5: CommitDate: 2012-08-21 11:54:07 +0300
Line 6: 
Line 7: Related to BZ#845020 - Diffferentiate bad specification from not found.
Line 8: 
Line 9: Already agreed that _devices should be a dict instead a list.
agreed with whom? why?
commit message should not contain 'conversations' just an explanation of
'what' the patch does and 'why'
Line 10: 
Line 11: Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36


....................................................
File vdsm/libvirtvm.py
Line 1628:                         device.volumeID) == tgetDrv):
Line 1629:                     return device
Line 1630:             else:
Line 1631:                 self.log.warning("drive dom: %s, img: %s, vol: %s is not
in"
Line 1632:                                  "vm: %s _devices",
drive["domainID"], 
trailing space
Line 1633:                                  drive["imageID"],
drive["volumeID"], self.id)
Line 1634:                 return None
Line 1635: 
Line 1636:         elif drive.has_key("GUID"):


--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Related to BZ#845020 - Diffferentiate bad specification from not found.
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/558/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

Yeela Kaplan has posted comments on this change.

Change subject: Related to BZ#845020 - Catch bad VM drive specification.
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.

Itamar Heim has posted comments on this change.

Change subject: Related to BZ#845020 - Catch bad VM drive specification.
......................................................................


Patch Set 2:

ping - still relevant?

-- 
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No