Dan Kenigsberg has uploaded a new change for review.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
dumpStorageTable: less statement-like prints
Change-Id: I01c8053e8545d033de2bfab34b0cade16de9823c Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/dumpStorageTable.py.in 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/38005/1
diff --git a/vdsm/dumpStorageTable.py.in b/vdsm/dumpStorageTable.py.in index 997aecb..82920fd 100644 --- a/vdsm/dumpStorageTable.py.in +++ b/vdsm/dumpStorageTable.py.in @@ -245,7 +245,7 @@
def _printRowSep(self, rowSep, columnNum): sepLine = '+' + (rowSep + '+') * columnNum - print sepLine + print(sepLine)
def _printTableSegment(self, depth, alignCenter=False, printHeader=False): '''Printing the Table''' @@ -287,7 +287,7 @@
line = line + ' %s |' % (adding)
- print '%s' % (line) + print(line) row += 1
self._printRowSep(rowSep, columnNum) @@ -319,5 +319,5 @@ msg = 'Unable to connect to vdsmd ' + str(se) rc = 1 if rc: - print >>sys.stderr, msg + sys.stderr.write(msg + '\n') sys.exit(rc)
automation@ovirt.org has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15897/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15096/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16067/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/873/ : FAILURE
Ido Barkan has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 1: Code-Review+1
Ido Barkan has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 1: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
dumpStorageTable: less statement-like prints
Change-Id: I01c8053e8545d033de2bfab34b0cade16de9823c Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: https://gerrit.ovirt.org/38005 Reviewed-by: Ido Barkan ibarkan@redhat.com Tested-by: Ido Barkan ibarkan@redhat.com --- M vdsm/dumpStorageTable.py.in 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Ido Barkan: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
automation@ovirt.org has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: dumpStorageTable: less statement-like prints ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/699/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4680/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/673/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/698/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6519/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/704/ : FAILURE
vdsm-patches@lists.fedorahosted.org