8:19 a.m.
Royce Lv has uploaded a new change for review.
Change subject: avoid _blockstatsParses throw exception when lacking some fields
......................................................................
avoid _blockstatsParses throw exception when lacking some fields
libvirt may return stats with some fields when running query-blockstats
avoid _blockstatsParses to throw exception when encounter keyError
Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com>
---
M vdsm/libvirtvm.py
M vdsm/storage/hsm.py
2 files changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/4304/1
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
5:42 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
using blockStatsFlags to collect disk latency instead of qemu cmd
in libvirtvm.py using blockStatsFlags to collect disk latency
instead of qemu cmd to avoid keyError and parse results our own
Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com>
---
M vdsm.spec.in
M vdsm/libvirtvm.py
2 files changed, 25 insertions(+), 73 deletions(-)
Approvals:
Royce Lv: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:34 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/816/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:10 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:38 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 8: Looks good to me, approved
thanks!
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
1:42 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
Thanks Royce, but now that this flag is defined in libvirt, let us use it.
....................................................
File vdsm/libvirtvm.py
Line 40: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm'
Line 41: # This device name is used as default both in the qemu-guest-agent
Line 42: # service/daemon and in libvirtd (to be used with the quiesce flag).
Line 43: _QEMU_GA_DEVICE_NAME = 'org.qemu.guest_agent.0'
Line 44: _TYPED_PARAM_STRING_OKAY = 4
why not use libvirt.VIR_TYPED_PARAM_STRING_OKAY instead?
Line 45:
Line 46:
Line 47: class MERGESTATUS:
Line 48: NOT_STARTED = "Not Started"
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:57 p.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vdsm.spec.in
Line 65: Requires: python >= 2.7.3
Line 66: Requires: qemu-kvm >= 2:0.15.0-4
Line 67: Requires: qemu-img >= 2:0.15.0-4
Line 68: #readonly lease ignored by default on 0.9.11.4-3
Line 69: Requires: libvirt >= 0.9.13-1
Igor, As this package is a rel one, I will bump the rhel version. I checked the community
release for fc, 0.9.13 does not include patch:
fix key error for qemuMonitorGetBlockStatsInfo
as changelog mentioned, this patch is included in 0.10.0, so I'll use this version
Line 70: Requires: libvirt-python, libvirt-lock-sanlock
Line 71: Requires: iscsi-initiator-utils >= 6.2.0.872-14
Line 72: Requires: device-mapper-multipath >= 0.4.9-18
Line 73: Requires: e2fsprogs >= 1.41.14
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:49 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 6: I would prefer that you didn't submit this
note: this would require some manual rebasing, now that libvirtvm conforms to pep8.
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:11 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Igor Lvovsky has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Thanks for the patch Royce.
Just a minor comment
....................................................
File vdsm.spec.in
Line 65: Requires: python >= 2.7.3
Line 66: Requires: qemu-kvm >= 2:0.15.0-4
Line 67: Requires: qemu-img >= 2:0.15.0-4
Line 68: #readonly lease ignored by default on 0.9.11.4-3
Line 69: Requires: libvirt >= 0.9.13-1
I think 0.9.13-3 is better.
* Fri Jul 20 2012 Daniel Veillard <veillard(a)redhat.com>
- libvirt-0.9.13-3.el6 - fix the package split to be similar to 6.3 one instead of
upstream
* Tue Jul 03 2012 Daniel Veillard <veillard(a)redhat.com>
- libvirt-0.9.13-2.el6 - fix a package dependency problem making -1 uninstallable
Line 70: Requires: libvirt-python, libvirt-lock-sanlock
Line 71: Requires: iscsi-initiator-utils >= 6.2.0.872-14
Line 72: Requires: device-mapper-multipath >= 0.4.9-18
Line 73: Requires: e2fsprogs >= 1.41.14
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:36 p.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/196/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:34 p.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 6: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/196/
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:51 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 5: I would prefer that you didn't submit this
submmitted wrong version
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
6:16 a.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 4:
Due to bug of libvirt, this patch will not be fully functional until my
patch(http://www.redhat.com/archives/libvir-list/2012-June/msg00879.html) accepted by
libvirt
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
3:10 p.m.
New subject: Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
thank you very much for this patch, and the libvirt work (I saw that Osier invited you to
go a level lower and send a qemu patch)!
you would also have to require a newer libvirt version in the spec file, once it is
ready.
....................................................
File vdsm/libvirtvm.py
Line 131: diskLatency[vmDrive.name] =
self._vm._dom.blockStatsFlags(vmDrive.name, flags=4)
please keep lines shorter, and use well-named CONSTANTS instead of magical numbers like
"4".
Line 132: self._log.info("Disk latency available:%s",
diskLatency[vmDrive.name])
no need to log the positive flow. it would fill up our logs too quickly.
(I think that logging the negative flow here was not very helpful, too)
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
1:56 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: avoid _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
we could take this, but I would very much prefer that we just start using
http://libvirt.org/html/libvirt-libvirt.html#virDomainBlockStatsFlags instead of parsing
json ourselves.
_blockstatsParses was a hack since libvirt did not support latency reports at the time.
note that we can assume that all our VM supports latency reports, no need to start
querying libvirt and qemu.
....................................................
Commit Message
Line 7: avoid _blockstatsParses throw exception when lacking some fields
please mention it's in libvirtvm - I almost forgot what it was.
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
11:33 a.m.
Adam Litke has posted comments on this change.
Change subject: avoid _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 153:
'flush_total_time_ns':devStats.get('flush_total_time_ns', 0)}
Should we use -1 as the default value so we can tell the difference between a real 0 and
no data?
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
10:23 p.m.
New subject: Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...
Xu He Jie has posted comments on this change.
Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 151:
'rd_total_time_ns':devStats('rd_total_time_ns', 0),
I think it should be 'devStats.get'
Line 153:
'flush_total_time_ns':devStats('flush_total_time_ns', 0)}
this repoduce on f16 with qemu-0.15.1-5.fc16.x86_64
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
12:28 a.m.
New subject: Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...
Mark Wu has posted comments on this change.
Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 2: (1 inline comment)
I am not sure if it's a real issue before I get the information asked in the inline
comments. So leave it as no score.
....................................................
File vdsm/libvirtvm.py
Line 153:
'flush_total_time_ns':devStats('flush_total_time_ns', 0)}
It seems the traceback was truncated. I just assume it throws key error on
'flush_operations'. Disk latency report including(flush) was added in
qemu-kvm-0.12.1.2-2.189.el6 (Please see https://bugzilla.redhat.com/show_bug.cgi?id=715017
for more details)
And the commit introducing this function also requires that qemu-kvm version should be
above 0.12.1.2-2.189.el6 ( Please see vdsm git commit
33ef12b3f3d510ed495fd9aa8b81f11e6c04941b).
So could you please check your qemu-kvm version and report how to reproduce it?
Thanks.
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
2:07 a.m.
New subject: Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...
Royce Lv has posted comments on this change.
Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 153:
'flush_total_time_ns':devStats('flush_total_time_ns', 0)}
This is changed because I got this error when testing recovering vm patch,
in this case libvirt and qemu has not got flush_operations stats:
Thread-55::ERROR::2012-05-10 13:32:04,328::utils::399::vm.Vm::(collect)
vmId=`f7c1b02f-b304-4e68-8565-3659b1214cb3`::Stats function failed:
<AdvancedStatsFunction _sampleDiskLatency at 0x23e8f10>
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 395,in collect
statsFunction()
File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 272, in __call__
retValue = self._function(*args, **kwargs)
File "/usr/share/vdsm/libvirtvm.py", line 163, in _sampleDiskLatency
stats = _blockstatsParses(out)
File "/usr/share/vdsm/libvirtvm.py", line 150, in _blockstatsParses
'flush_op':devStats['flush_operations'],
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
2:04 a.m.
New subject: Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...
Royce Lv has posted comments on this change.
Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 155:
'flush_total_time_ns':devStats['flush_total_time_ns']}
Mark, actually this stats is vdsm call libvirt call qemu to get the stats, in some of my
test case the flush_ops stats can't be got from qemu. I believe even when qemu not got
this stats in some condition or because of some err, vdsm should not throw a exception.
....................................................
File vdsm/storage/hsm.py
Line 317: self.log.info("lvroyce find storage pool file")
sorry for introduce my personal log mistakenly:(
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
4:35 a.m.
Mark Wu has posted comments on this change.
Change subject: avoid _blockstatsParses throw exception when lacking some fields
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 155:
'flush_total_time_ns':devStats['flush_total_time_ns']}
Could you please explain in which case libvirt can't return all the fields? Do we have
any method to avoid it? If it really happens, you should change to use
devStats.get(keyname, 0). Otherwise, the fields below the missing one can't get
chance to be updated even if it really appears. Then you needn't use "try"
to capture "KeyError" exception
....................................................
File vdsm/storage/hsm.py
Line 317: self.log.info("lvroyce find storage pool file")
All the change in this file is your personal debugging message, not related to the fix.
Please remove it.
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
4106
days inactive
4222
days old
vdsm-patches@lists.fedorahosted.org
20 comments
7 participants
participants (7)
-
agl＠us.ibm.com -
Dan Kenigsberg -
Igor Lvovsky -
Jenkins CI RO -
lvroyce＠linux.vnet.ibm.com -
wudxw＠linux.vnet.ibm.com -
Xu He Jie