Change in vdsm[master]: fix comment

Arik Hadas has uploaded a new change for review.

Change subject: fix comment
......................................................................

fix comment

The comment on _getConfigVmStats mention the 'display' field
but this field is no longer set in this method, thus this
part is removed.

Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/64972/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 967dbab..c38eaef 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1218,7 +1218,7 @@
         """
         provides all the stats which will not change after a VM is booted.
         Please note that some values are provided by client (engine)
-        but can change as result as interaction with libvirt (display*)
+        but can change as a result of interaction with libvirt
         """
         stats = {
             'vmId': self.conf['vmId'],


-- 
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: fix comment
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Arik Hadas has posted comments on this change.

Change subject: fix comment
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: fix comment
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: fix comment
......................................................................


fix comment

The comment on _getConfigVmStats mention the 'display' field
but this field is no longer set in this method, thus this
part is removed.

Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/64972
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: fix comment
......................................................................


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie234c9a1dd0fde9da85356ae253c39da608ebf01
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No