Laszlo Hornyak has uploaded a new change for review.
Change subject: pep8 cleanup ......................................................................
pep8 cleanup
removed some pep8 errors
Signed-off-by: Laszlo Hornyak lhornyak@redhat.com Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 --- M tests/capsTests.py M vdsm/caps.py 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/10032/1
diff --git a/tests/capsTests.py b/tests/capsTests.py index dec0ec7..b39e8e2 100644 --- a/tests/capsTests.py +++ b/tests/capsTests.py @@ -67,8 +67,8 @@ path = os.path.join(dirName, "caps_libvirt.out") machines = caps._getEmulatedMachines(file(path).read()) expectedMachines = ['pc-1.2', 'none', 'pc', 'pc-1.1', 'pc-1.0', - 'pc-0.15', 'pc-0.14', 'pc-0.13', 'pc-0.12', 'pc-0.11', - 'pc-0.10', 'isapc'] + 'pc-0.15', 'pc-0.14', 'pc-0.13', 'pc-0.12', + 'pc-0.11', 'pc-0.10', 'isapc'] self.assertEqual(machines, expectedMachines)
def test_parseKeyVal(self): diff --git a/vdsm/caps.py b/vdsm/caps.py index 0b16796..d6298df 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -135,6 +135,7 @@ if m.nodeName == 'machine'] return []
+ def _getAllCpuModels(): cpu_map = minidom.parseString( file('/usr/share/libvirt/cpu_map.xml').read())
-- To view, visit http://gerrit.ovirt.org/10032 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8 cleanup ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/361/ (1/2)
-- To view, visit http://gerrit.ovirt.org/10032 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8 cleanup ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/327/ (2/2)
-- To view, visit http://gerrit.ovirt.org/10032 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8 cleanup ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/327/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/361/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/10032 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: pep8 cleanup ......................................................................
Patch Set 1: Do not submit
sorry Laszlo, as this issue has already been fixed, I suppose this change should follow the destination of http://gerrit.ovirt.org/#/c/10025/
thanks!
-- To view, visit http://gerrit.ovirt.org/10032 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Laszlo Hornyak has abandoned this change.
Change subject: pep8 cleanup ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/10032 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ib7c118947504f0bda5a922b5da07dca01c2cfca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org