Change in vdsm[ovirt-3.4]: vm: do not pause during refreshVolume

[Federico Simoncelli]

Hello Ayal Baron, Allon Mureinik,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/24038

to review the following change.

Change subject: vm: do not pause during refreshVolume
......................................................................

vm: do not pause during refreshVolume

There's no need to pause the VM during the logical volume refresh as LVM
is taking care of freezing the IO during the dm table update.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=889097
Change-Id: I896993c00b94c3255ad2007486e0589bf10b3a98
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/8382
Reviewed-by: Ayal Baron <abaron(a)redhat.com&gt;
Reviewed-by: Allon Mureinik <amureini(a)redhat.com&gt;
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/24038/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 7c2d496..bf64195 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2489,19 +2489,8 @@
             self.__extendDriveVolume(vmDrive, newSize)
 
     def __refreshDriveVolume(self, volInfo):
-        """ Stop vm before refreshing LV. """
-
-        self._guestCpuLock.acquire()
-        try:
-            wasRunning = self._guestCpuRunning
-            if wasRunning:
-                self.pause(guestCpuLocked=True)
-            self.cif.irs.refreshVolume(volInfo['domainID'],
volInfo['poolID'],
-                                       volInfo['imageID'],
volInfo['volumeID'])
-            if wasRunning:
-                self.cont(guestCpuLocked=True)
-        finally:
-            self._guestCpuLock.release()
+        self.cif.irs.refreshVolume(volInfo['domainID'],
volInfo['poolID'],
+                                   volInfo['imageID'],
volInfo['volumeID'])
 
     def __verifyVolumeExtension(self, volInfo):
         self.log.debug("Refreshing drive volume for %s (domainID: %s, "


-- 
To view, visit http://gerrit.ovirt.org/24038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I896993c00b94c3255ad2007486e0589bf10b3a98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vm: do not pause during refreshVolume
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/24038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I896993c00b94c3255ad2007486e0589bf10b3a98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm: do not pause during refreshVolume
......................................................................


vm: do not pause during refreshVolume

There's no need to pause the VM during the logical volume refresh as LVM
is taking care of freezing the IO during the dm table update.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=889097
Change-Id: I896993c00b94c3255ad2007486e0589bf10b3a98
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/8382
Reviewed-by: Ayal Baron <abaron(a)redhat.com&gt;
Reviewed-by: Allon Mureinik <amureini(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/24038
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 13 deletions(-)

Approvals:
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I896993c00b94c3255ad2007486e0589bf10b3a98
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: vm: do not pause during refreshVolume
......................................................................


Patch Set 1: Verified+1

Same as master.

-- 
To view, visit http://gerrit.ovirt.org/24038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I896993c00b94c3255ad2007486e0589bf10b3a98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-HasComments: No