Dan Kenigsberg has uploaded a new change for review.
Change subject: drop unused checkPathStat ......................................................................
drop unused checkPathStat
We actually have two copies of this junk DNA. Trim it.
Change-Id: I6d3017b2cc13134253284248258879c6140d26de Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/utils.py M vdsm/sampling.py 2 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/20673/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 7310529..7551d0a 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -559,16 +559,6 @@ return (proc.returncode, out, err)
-def checkPathStat(pathToCheck): - try: - startTime = time.time() - os.statvfs(pathToCheck) - delay = time.time() - startTime - return (True, delay) - except: - return (False, 0) - - class ImagePathStatus(threading.Thread): def __init__(self, cif, interval=None): if interval is None: diff --git a/vdsm/sampling.py b/vdsm/sampling.py index 2849e75..851034d 100644 --- a/vdsm/sampling.py +++ b/vdsm/sampling.py @@ -541,16 +541,6 @@ return stats
-def checkPathStat(pathToCheck): - try: - startTime = time.time() - os.statvfs(pathToCheck) - delay = time.time() - startTime - return (True, delay) - except: - return (False, 0) - - class ImagePathStatus(threading.Thread): def __init__(self, cif, interval=None): if interval is None:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: drop unused checkPathStat ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5125/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4321/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5199/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: drop unused checkPathStat ......................................................................
Patch Set 1: Code-Review+1
Petr Šebek has posted comments on this change.
Change subject: drop unused checkPathStat ......................................................................
Patch Set 1: Verified+1 Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: drop unused checkPathStat ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: drop unused checkPathStat ......................................................................
drop unused checkPathStat
We actually have two copies of this junk DNA. Trim it.
Change-Id: I6d3017b2cc13134253284248258879c6140d26de Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/20673 Reviewed-by: Mark Wu wudxw@linux.vnet.ibm.com Tested-by: Petr Šebek psebek@redhat.com Reviewed-by: Petr Šebek psebek@redhat.com --- M lib/vdsm/utils.py M vdsm/sampling.py 2 files changed, 0 insertions(+), 20 deletions(-)
Approvals: Mark Wu: Looks good to me, but someone else must approve Petr Šebek: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org