Change in vdsm[master]: Don't fail hotplugNic operation when after hook fails

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Don't fail hotplugNic operation when after hook fails
......................................................................

Don't fail hotplugNic operation when after hook fails

Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015171
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vdsm/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/20876/1

diff --git a/vdsm/hooks.py b/vdsm/hooks.py
index a801a15..c983326 100644
--- a/vdsm/hooks.py
+++ b/vdsm/hooks.py
@@ -251,7 +251,7 @@
 
 def after_nic_hotplug(nicxml, vmconf={}, params={}):
     return _runHooksDir(nicxml, 'after_nic_hotplug', vmconf=vmconf,
-                        params=params)
+                        params=params, raiseError=False)
 
 
 def before_nic_hotunplug(nicxml, vmconf={}, params={}):


-- 
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Don't fail hotplugNic operation when after hook fails
......................................................................


Don't fail hotplugNic operation when after hook fails

Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015171
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/20876
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Don't fail hotplugNic operation when after hook fails
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: Don't fail hotplugNic operation when after hook fails
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Don't fail hotplugNic operation when after hook fails
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4412/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5216/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5292/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Antoni Segura Puimedon has posted comments on this change.

Change subject: Don't fail hotplugNic operation when after hook fails
......................................................................


Patch Set 1: Code-Review+1

Thanks Yaniv!

-- 
To view, visit http://gerrit.ovirt.org/20876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No