Change in vdsm[master]: [WIP]add createVm support of cputune

Royce Lv has uploaded a new change for review.

Change subject: [WIP]add createVm support of cputune
......................................................................

[WIP]add createVm support of cputune

allow engine to pass other cputune params through vm create,
createVm now uses nice to config vm share value,
this patch uses 'shares' in vmdef directly (1024 by default)

Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Signed-off-by: Royce Lv
---
M vdsm/libvirtvm.py
1 file changed, 13 insertions(+), 11 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/8445/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index fd80c69..9b38a36 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -737,10 +737,13 @@
         self.dom.appendChild(cpu)

def appendTunable(self):
-        #CPU-pinning support
-        # see http://www.ovirt.org/wiki/Features/Design/cpu-pinning
+        cputune = self.doc.createElement('cputune')
+        cputuneParams = {'shares':1024}
+        if 'cputune' in self.conf:
+            cputuneParam = self.conf['cputune']
         if 'cpuPinning' in self.conf:
-            cputune = self.doc.createElement('cputune')
+            #CPU-pinning support
+            # see http://www.ovirt.org/wiki/Features/Design/cpu-pinning
             cpuPinning = self.conf.get('cpuPinning')
             try:
                 emulatorset = cpuPinning.pop('emulator')
@@ -754,7 +757,13 @@
                 vcpupin.setAttribute('vcpu', cpuPin)
                 vcpupin.setAttribute('cpuset', cpuPinning[cpuPin])
                 cputune.appendChild(vcpupin)
-            self.dom.appendChild(cputune)
+
+        for item in cputuneParams.keys():
+            m = self.doc.createElement(item)
+            m.appendChild(self.doc.createTextNode(cputuneParams[item]))
+            cputune.appendChild(m)
+
+        self.dom.appendChild(cputune)

def _appendAgentDevice(self, path, name):
         """
@@ -1338,13 +1347,6 @@
             if self._initTimePauseCode == 'ENOSPC':
                 self.cont()
         self.conf['pid'] = self._getPid()
-
-        nice = int(self.conf.get('nice', '0'))
-        nice = max(min(nice, 19), 0)
-        try:
-            self._dom.setSchedulerParameters({'cpu_shares': (20 - nice) * 51})
-        except:
-            self.log.warning('failed to set Vm niceness', exc_info=True)

def _run(self):
         self.log.info("VM wrapper has started")

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv

Change in vdsm[master]: add createVm support of cputune

[Ryan Harper]

Ryan Harper has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2336:           'display': 'VmDisplayType', 'displayIp': 'str',
Line 2337:           'displayPort': 'uint', 'displaySecurePort': 'uint',
Line 2338:           'emulatedMachine': 'str', 'keyboardLayout': 'str',
Line 2339:           'kvmEnable': 'bool', 'memSize': 'uint',
Line 2340:           'nicModel': 'str', 'pauseCode': 'str',
We're removing the nice value, where is the cpuTune parameter then?
Line 2341:           'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Line 2342:           '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2343:           'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2344:           'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}}

....................................................
File vdsm/libvirtvm.py
Line 737:         self.dom.appendChild(cpu)
Line 738: 
Line 739:     def appendTunable(self):
Line 740:         cputune = self.doc.createElement('cputune')
Line 741:         cputuneParams = {'shares': '1024'}
The default nice level is stored in vdsm.conf, we should do the same for the cputune default value as well.
Line 742:         # keep 'cpuTune' and 'cpuPinning' for engine bc.
Line 743:         if 'cpuTune' in self.conf:
Line 744:             cputuneParams = self.conf['cpuTune']
Line 745:         if 'cpuPinning' in self.conf:

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper

Change in vdsm[master]: add createVm support of cputune

Royce Lv has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 4: Verified

Dan, could you give some advice on whether we should preserve the 'nice' or not? Thanks!

Tested:
(1)previous cpuPinning interface
(2)cpuPinning include in cputune
(3)cputune set
(4)normal vm start

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper

Change in vdsm[master]: add createVm support of cputune

Royce Lv has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 3: (2 inline comments)

In the new version I just leave libvirt to care the default value to distinguish the situation we set 'tune' or not. Is that Ok?

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2336:           'display': 'VmDisplayType', 'displayIp': 'str',
Line 2337:           'displayPort': 'uint', 'displaySecurePort': 'uint',
Line 2338:           'emulatedMachine': 'str', 'keyboardLayout': 'str',
Line 2339:           'kvmEnable': 'bool', 'memSize': 'uint',
Line 2340:           'nicModel': 'str', 'pauseCode': 'str',
Done
Line 2341:           'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Line 2342:           '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2343:           'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2344:           'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}}

....................................................
File vdsm/libvirtvm.py
Line 737:         self.dom.appendChild(cpu)
Line 738: 
Line 739:     def appendTunable(self):
Line 740:         cputune = self.doc.createElement('cputune')
Line 741:         cputuneParams = {'shares': '1024'}
Ryan,
For the default nice we use:
nice = int(self.conf.get('nice', '0'))

looked into the code and see this not preserved in conf.But I total agree with you on that because we need to query the live tune value so we need to keep it in conf.
Line 742:         # keep 'cpuTune' and 'cpuPinning' for engine bc.
Line 743:         if 'cpuTune' in self.conf:
Line 744:             cputuneParams = self.conf['cpuTune']
Line 745:         if 'cpuPinning' in self.conf:

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper

Change in vdsm[master]: add createVm support of cputune

Michal Skrivanek has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra

Change in vdsm[master]: add createVm support of cputune

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 4: I would prefer that you didn't submit this

marking -1 just because it is based on a nack'ed change. Please fix http://gerrit.ovirt.org/8411 and rebase.

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/307/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/273/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/273/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/307/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Doron Fediuck has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Royce Lv has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Peter V. Saveliev has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 5:

btw, shouldn't we change the REST schema as well?

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/499/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/464/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 6: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/464/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/499/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/467/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/502/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/467/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/502/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Doron Fediuck has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 7: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Royce Lv has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 7: Verified

past unittest of generate xml and functional of create vm on local storage vm tune and BC of cpuPinning

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 7: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2482: # @quota:            #optional Max bandwidth vCPU can consume
Line 2483: #
Line 2484: # @shares:           #optional Relative share of CPU compared with other VMs
Line 2485: #
Line 2486: # Since: 4.10.0
4.10.3?
Line 2487: ##
Line 2488: {'type': 'CpuTuneParams',
Line 2489:  'data': {'*cpuPinning': 'StringMap', '*emulator_period': 'uint',
Line 2490:  '*emulator_quota': 'int', '*period': 'uint',

Line 2496: # Type that includes all tunable parameters for @VM.create.
Line 2497: #
Line 2498: # @cpu:        Limits of CPU and emulator thread.
Line 2499: #
Line 2500: # Since: 4.10.0
4.10.3?
Line 2501: ##
Line 2502: {'type': 'TuneType',
Line 2503:  'data': {'cpu': 'CpuTuneParams'}}
Line 2504:

....................................................
File vdsm/libvirtvm.py
Line 815:                 return
Line 816: 
Line 817:         for tuneKey, tuneValue in self.conf['tune'].iteritems():
Line 818:             funName = '_append' + tuneKey.capitalize() + "Tune"
Line 819:             tuneFun = getattr(self, funName)
Shouldn't we check before we call that?
Or is it intentional that it'll throw an exception during creation?

Honestly I don't really think this is a good idea
Line 820:             tuneFun(tuneValue)
Line 821: 
Line 822:     def _appendAgentDevice(self, path, name):
Line 823:         """

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/516/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/481/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/481/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/516/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Royce Lv has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8: Verified

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Peter V. Saveliev has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Doron Fediuck has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/742/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/707/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/707/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/742/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: add createVm support of cputune

Itamar Heim has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

ping?

Change in vdsm[master]: add createVm support of cputune

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9: Code-Review+1

Change in vdsm[master]: add createVm support of cputune

Itamar Heim has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

what's needed to get closure onthis?

Change in vdsm[master]: add createVm support of cputune

Itamar Heim has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

ping?

Change in vdsm[master]: add createVm support of cputune

Francesco Romani has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

We can still save something from this patch, but it is probably more effective to just save ideas and concepts, because the code needs a truckload of work to be made up to date.

Change in vdsm[master]: add createVm support of cputune

Saggi Mizrahi has posted comments on this change.

Change subject: add createVm support of cputune
......................................................................

Patch Set 9:

Removing myself from reviewers.

Change in vdsm[master]: add createVm support of cputune

Itamar Heim has abandoned this change.

Change subject: add createVm support of cputune
......................................................................

Abandoned

no activity for 60 days + last comment by francesco