10:58 a.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
vdsm/Makefile.am: fix make install
currently vdsm-logrotate.conf is not generated automatically, which break the 'make
install'
[vdsmdevel@medogz vdsm]$ sudo make install
[sudo] password for vdsmdevel:
<snip>
/usr/bin/install -c -m 644 vdsm.rwtab \
/etc/rwtab.d/vdsm
/bin/mkdir -p /etc/logrotate.d
/usr/bin/install -c -m 644 ./vdsm-logrotate.conf \
/etc/logrotate.d/vdsm
/usr/bin/install: cannot stat `./vdsm-logrotate.conf': No such file or directory
make[3]: *** [install-data-logrotate] Error 1
make[3]: Leaving directory `/home/vdsmdevel/sem-patch/vdsm/vdsm'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/vdsmdevel/sem-patch/vdsm/vdsm'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/vdsmdevel/sem-patch/vdsm/vdsm'
make: *** [install-recursive] Error 1
[vdsmdevel@medogz vdsm]$
Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
---
M vdsm/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/1124/1
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
3:11 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
vdsm/Makefile.am: fix make install
currently vdsm-logrotate.conf is not generated automatically, which break the 'make
install'
[vdsmdevel@medogz vdsm]$ sudo make install
[sudo] password for vdsmdevel:
<snip>
/usr/bin/install -c -m 644 vdsm.rwtab \
/etc/rwtab.d/vdsm
/bin/mkdir -p /etc/logrotate.d
/usr/bin/install -c -m 644 ./vdsm-logrotate.conf \
/etc/logrotate.d/vdsm
/usr/bin/install: cannot stat `./vdsm-logrotate.conf': No such file or directory
make[3]: *** [install-data-logrotate] Error 1
make[3]: Leaving directory `/home/vdsmdevel/sem-patch/vdsm/vdsm'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/vdsmdevel/sem-patch/vdsm/vdsm'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/vdsmdevel/sem-patch/vdsm/vdsm'
make: *** [install-recursive] Error 1
[vdsmdevel@medogz vdsm]$
Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
---
M vdsm/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Saggi Mizrahi: Looks good to me, but someone else must approve
Federico Simoncelli: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:11 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1: Looks good to me, approved
Douglas, go ahead and remove vdsm-gencerts.sh from dist (vdsm.spec is there
intentionally).
I usually like verbosity, but I agree with Federico, that in this case the comment is less
useful than an explanation why the bug popped up, and how it was solved.
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:23 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Odd, `make install` works for me as it is (as well as make rpm which uses it). Can you
trace what commit broke the build for you?
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:12 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:59 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
9:49 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1:
Hi Dan,
Below the commit that I do believe broke the vdsm-logrotate.conf stuff. It just rename the
vdsm-logrotate.conf to vdsm-logrotate.conf.in but doesn't add a rule to generate it.
commit 951b41dd511ff0003924592d2ae8cd69b8174197
Author: huntxu <mhuntxu(a)gmail.com>
Date: Wed Dec 7 10:33:17 2011 +0800
BZ#772591 Specify which user/group should be used for core dumps rotation
Finally, it seems we have more people facing this problem, today at #vdsm channel we got:
#vdsm
<snip>
<roi_> i have new error now
<roi_> .
<roi_> /usr/bin/install: cannot stat `./vdsm-logrotate.conf': No such file
or directory
<roi_> make[3]: *** [install-data-logrotate] Error 1
</snip>
Thanks
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Thanks for catching this. Please verify that the tar.gz (make dist) doesn't ship any
file that should be generated. BTW I'm not a fan of such large error messages in the
commit.
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:46 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1: No score
Ok, actually I can reproduce this, but do not understand why `make rpm` is not affected.
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11:14 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm/Makefile.am: fix make install
......................................................................
Patch Set 1:
Hi Federico,
Thanks for your review. I have reviewed the .tar.gz generated by make dist and found that
we have these two files shipped:
vdsm.spec
vdsm.spec.in
vdsm-gencerts.sh
vdsm-gencerts.sh.in
Which looks like another patch maybe needed.
About the long commit message, I usually use this message format because users can use
search pages like google to find bugs solutions with the error message.
Thanks
Douglas
--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4500
days inactive
4504
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Federico Simoncelli -
smizrahi＠redhat.com