9:50 a.m.
Francesco Romani has uploaded a new change for review.
Change subject: pep8: fix line too long
......................................................................
pep8: fix line too long
restore proper line length. http://gerrit.ovirt.org/#/c/27846 has a
better fix.
Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/27878/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index a547a5e..ca4029a 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4855,7 +4855,8 @@
device of each type (sdl, vnc, spice) is supported
"""
graphicsXml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
-
getElementsByTagName('devices')[0].getElementsByTagName('graphics')[0]
+ getElementsByTagName('devices')[0]. \
+ getElementsByTagName('graphics')[0]
graphicsType = graphicsXml.getAttribute('type')
for dev in self.conf['devices']:
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
10:49 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: fix line too long
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1313/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:45 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: fix line too long
......................................................................
pep8: fix line too long
commit b867894ea34ec710cc261646edf3283b90f2dec4 introduced a pep8
error. This patch fixes that.
Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27878
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10:45 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: fix line too long
......................................................................
Patch Set 2: Code-Review+2
gitpydiff is happy, pep8 is happy, so am I.
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:09 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: fix line too long
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9010/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9151/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8222/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:08 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: fix line too long
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9009/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9150/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8221/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:52 a.m.
Francesco Romani has posted comments on this change.
Change subject: pep8: fix line too long
......................................................................
Patch Set 1: Verified+1
pep8 happy, gitpydiff silent.
--
To view, visit http://gerrit.ovirt.org/27878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If59e46fa2a7766369ffe9048320144add5404a69
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3640
days inactive
3640
days old
vdsm-patches@lists.fedorahosted.org
6 comments
3 participants
participants (3)
-
Dan Kenigsberg -
fromani＠redhat.com -
Jenkins CI RO