Dan Kenigsberg has uploaded a new change for review.
Change subject: storage: drop an unused configurable sd_validate_timeout ......................................................................
storage: drop an unused configurable sd_validate_timeout
Change-Id: Ic77b0a6f71f40fc0f3c0b51d04cc7ca77182a09d Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/config.py.in M vdsm/storage/hsm.py 2 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/21060/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in index c0bdd53..0cb4048 100644 --- a/lib/vdsm/config.py.in +++ b/lib/vdsm/config.py.in @@ -204,10 +204,6 @@ ('vol_size_sample_interval', '60', 'How often should the volume size be checked (seconds).'),
- ('sd_validate_timeout', '80', - 'Storage domain validate timeout, the maximum number of seconds ' - 'to wait until all the domains will be validated.'), - ('scsi_rescan_minimal_timeout', '2', 'The minimum number of seconds to wait for scsi scan to return.'),
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 25340f5..e62721f 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -332,7 +332,6 @@ rm.ResourceManager.getInstance().registerNamespace( STORAGE, rm.SimpleResourceFactory()) self.storage_repository = config.get('irs', 'repository') - self.sd_validate_timeout = config.getint('irs', 'sd_validate_timeout') self.taskMng = taskManager.TaskManager()
mountBasePath = os.path.join(self.storage_repository,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4494/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5294/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5372/ : SUCCESS
Sergey Gotliv has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout ......................................................................
Patch Set 1: Verified+1
Federico Simoncelli has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: drop an unused configurable sd_validate_timeout ......................................................................
storage: drop an unused configurable sd_validate_timeout
Change-Id: Ic77b0a6f71f40fc0f3c0b51d04cc7ca77182a09d Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/21060 Reviewed-by: Sergey Gotliv sgotliv@redhat.com Reviewed-by: Federico Simoncelli fsimonce@redhat.com --- M lib/vdsm/config.py.in M vdsm/storage/hsm.py 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: Federico Simoncelli: Looks good to me, approved Sergey Gotliv: Looks good to me, but someone else must approve Dan Kenigsberg: Verified
vdsm-patches@lists.fedorahosted.org