Change in vdsm[master]: spec: use native ssl implementation in Fedora

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: spec: use native ssl implementation in Fedora
......................................................................

spec: use native ssl implementation in Fedora

Vdsm no longer work with Fedora 25's m2crypto. Let us use the native
implementaiton instead.

Change-Id: Id4c0f461b93bbfbd2c9e350eaa6a7cd8d3760047
Signed-off-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/71248/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index dbf2267..dc37287 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -711,7 +711,9 @@
        -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \
        -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' lib/vdsm/dsaversion.py

+%if ! 0%{?fedora} >= 25
 sed -i -e 's/@SSL_IMPLEMENTATION@/m2c/g' lib/vdsm/config.py
+%endif

sed -i -e 's@VDSMRPCPYLIBDIR@%{python_sitelib}/%{vdsm_name}/rpc\g' lib/vdsm/constants.py

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: use native ssl implementation in Fedora
......................................................................

Patch Set 2: Code-Review-1

We test ssl, but we ship m2c. That's why we did not catch the f25 regression. yes, we should test both. but also, we hate m2c. there's no reason to keep it in Fedora.

But the proper way to handle it is with a --with-ssl-implementation argument to configure

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: use native ssl implementation in Fedora
......................................................................

Patch Set 2:

nobody likes autoconf... but having logic in the spec is wrong.

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change.

Change subject: spec: use native ssl implementation in Fedora
......................................................................

Abandoned

we manage to work find with fc25's m2c. Using native ssl in Fedora would have to wait.