From Dan Kenigsberg danken@redhat.com:
Hello Jonathan Dieter,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/75909
to review the following change.
Change subject: Remove deprecated listen attribute ......................................................................
Remove deprecated listen attribute
Tested using ovirt-engine-4.1.1.8 and vdsm-4.19.10.1 with this patch applied.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1437523
Change-Id: Ibe44ccfc70bba2ad9deabef3a33473725ab7fbbe Signed-off-by: Jonathan Dieter jdieter@lesbg.com --- M vdsm/virt/vm_migrate_hook.py 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/75909/1
diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py index 635e5b8..59cdfa6 100755 --- a/vdsm/virt/vm_migrate_hook.py +++ b/vdsm/virt/vm_migrate_hook.py @@ -190,11 +190,13 @@ graphics_listen.attrib.pop('network', None) graphics_listen.set('type', 'address') graphics_listen.set('address', target_display_ip) + graphics.attrib.pop('listen', None) else: libvirt_network = net_api.netname_o2l(target_display_network) graphics_listen.attrib.pop('address', None) graphics_listen.set('type', 'network') graphics_listen.set('network', libvirt_network) + graphics.attrib.pop('listen', None)
def _vmconf_display(vm_conf):
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: Remove deprecated listen attribute ......................................................................
Patch Set 1: Code-Review+1 Verified+1
copying verification score, raising code-review
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: Remove deprecated listen attribute ......................................................................
Patch Set 1: Code-Review+2
vdsm-patches@lists.fedorahosted.org