Change in vdsm[master]: vdsm: LibvirtVm._cleanup redundant call removed

Vered Volansky has uploaded a new change for review.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

vdsm: LibvirtVm._cleanup redundant call removed

In libvirtvm.py: LibvirtVm._cleanup on hotunplug success seems wrong and
was removed.

Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Signed-off-by: Vered Volansky 
---
M vdsm/libvirtvm.py
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/12564/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index e2ada06..0890daf 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1814,8 +1814,6 @@
             return {
                 'status': {'code': errCode['hotunplugDisk']['status']['code'],
                            'message': e.message}}
-        else:
-            self._cleanup()

return {'status': doneCode, 'vmList': self.status()}

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/589/ (3/3)

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1481/ (1/3)

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1442/ (2/3)

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1:

Build Started http://alterway01.ovirt.org/job/vdsm_unit_tests_gerrit/1459/ (1/2)

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1:

Build Started http://alterway01.ovirt.org/job/vdsm_pep8_gerrit/1422/ (2/2)

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1: Fails

Build Failed

http://alterway01.ovirt.org/job/vdsm_pep8_gerrit/1422/ : SUCCESS

http://alterway01.ovirt.org/job/vdsm_unit_tests_gerrit/1459/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1: No score

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1442/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1481/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/589/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Is it really redundant? Any idea what was its motivation? Better ask Igor ;-)

I suspect that it causes a bug or two, and we should consider backporting (if we care for unplug). Either way, considerable verification is due.

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1:

A "competing" patch is in http://gerrit.ovirt.org/13610

please track this issue there.

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Vered Volansky has abandoned this change.

Change subject: vdsm: LibvirtVm._cleanup redundant call removed
......................................................................

Patch Set 1: Abandoned

Dealt with in 13610

--
To view, visit http://gerrit.ovirt.org/12564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2999186d475eb382a03c977c232a66dd08545de9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server