10 p.m.
Saggi Mizrahi has uploaded a new change for review.
Change subject: Add fileUtil unit tests
......................................................................
Add fileUtil unit tests
Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
---
M tests/Makefile.am
A tests/fileUtilTests.py
A tests/testValidation.py
M tests/testrunner.py
4 files changed, 222 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/3264/1
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
3:28 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add fileUtil unit tests
......................................................................
Add fileUtil unit tests
Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
---
M tests/Makefile.am
A tests/fileUtilTests.py
A tests/testValidation.py
M tests/testrunner.py
4 files changed, 225 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
3:28 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 6: Verified; Looks good to me, approved
ok, ok. I still hate this hack, but let's take this in now.
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
6:08 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/testrunner.py
Line 176: sys.modules['vdsm.constants'] = mod.constants
could you do this for all sitelib packages automatically?
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:12 p.m.
Federico Simoncelli has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:56 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/testrunner.py
Line 159: # Remove this when source is properly orgenized.
how "obtrusive" is a script creating a shadow sitelib package?
I may be daft, I know, but could you explain here how the hack solves the problem, and
what's so special about these two modules? it seems to me that any sitelib package
would require this.
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:48 p.m.
Peter V. Saveliev has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 3: Fails
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:35 p.m.
Peter V. Saveliev has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:22 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/testrunner.py
Line 159: # Remove this when source is properly orgenized.
All other modules don't have to be hacked in like that. They are imported properly.
This will go away once we fix the codebase.
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:05 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/testrunner.py
Line 159: # Remove this when source is properly orgenized.
My original fix was to add a sub dir called vdsm and add symlinks to it.
But this seems less obtrusive to the codebase.
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:11 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Add fileUtil unit tests
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/testrunner.py
Line 159: # Remove this when source is properly orgenized.
s/orgenized/..
I do not understand this hack, and I do not know how it cat be reasonably be extended to
incorporate all testable modules.
I would prefer the tests to assume that the git repo structure below vdsm is a superset of
the sitelib vdsm package. Wouldn't it work "by chance"?
If that's too ugly/impossible, how about creating a shadow sitelib under /tmp when
testrunner starts?
--
To view, visit http://gerrit.ovirt.org/3264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4425
days inactive
4431
days old
vdsm-patches@lists.fedorahosted.org
10 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Federico Simoncelli -
peet＠redhat.com -
smizrahi＠redhat.com