Change in vdsm[master]: (Schema) Remove deprecated network API functinos

Saggi Mizrahi has uploaded a new change for review.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

(Schema) Remove deprecated network API functinos

Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 0 insertions(+), 66 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/6838/1
--
To view, visit http://gerrit.ovirt.org/6838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

Patch Set 1: I would prefer that you didn't submit this

You would also need to remove the 'NetworkOptions' type since it has no users anymore.

--
To view, visit http://gerrit.ovirt.org/6838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer

Livnat Peer has posted comments on this change.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

Patch Set 2: I would prefer that you didn't submit this

The API was changed lately to include bridges section in setup networks.

the cfg section for network is deprecated. we need it only for devices and not for networks going forward.

--
To view, visit http://gerrit.ovirt.org/6838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

Patch Set 2:

I'm sorry but I don't understand what I should change in my patch. In any case I wonder if you could just take the patch and have someone from networking fix it.

--
To view, visit http://gerrit.ovirt.org/6838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Saggi Mizrahi

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/439/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/6838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

Patch Set 4:

ping?

Itamar Heim has abandoned this change.

Change subject: (Schema) Remove deprecated network API functinos
......................................................................

Abandoned

no reply - abandoning - please restore if still relevant