7:30 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: rpmlint: silence warning about zero-length conf files
......................................................................
rpmlint: silence warning about zero-length conf files
rpmlint does not like empty conf files, so we're shipping them with a
single newline.
Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.sh
M static/etc/vdsm/mom.d/01-parameters.policy
M tests/toolTests_empty.conf
3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/73455/1
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index f7faf55..6bb0804 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -33,6 +33,6 @@
# TODO: fix spec to stop ignoring the few current errors
! rpmlint "$EXPORT_DIR/"!(*.src).rpm | grep ': E: ' | grep -v
explicit-lib-dependency | \
- grep -v no-binary | grep -v zero-length | \
+ grep -v no-binary | \
grep -v non-readable | grep -v non-standard-dir-perm
fi
diff --git a/static/etc/vdsm/mom.d/01-parameters.policy
b/static/etc/vdsm/mom.d/01-parameters.policy
index e69de29..8b13789 100644
--- a/static/etc/vdsm/mom.d/01-parameters.policy
+++ b/static/etc/vdsm/mom.d/01-parameters.policy
@@ -0,0 +1 @@
+
diff --git a/tests/toolTests_empty.conf b/tests/toolTests_empty.conf
index e69de29..8b13789 100644
--- a/tests/toolTests_empty.conf
+++ b/tests/toolTests_empty.conf
@@ -0,0 +1 @@
+
--
To view, visit https://gerrit.ovirt.org/73455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
8:17 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: rpmlint: silence warning about zero-length conf files
......................................................................
Patch Set 1:
ci please build
--
To view, visit https://gerrit.ovirt.org/73455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
8:35 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: rpmlint: silence warning about zero-length conf files
......................................................................
Patch Set 1:
http://jenkins.ovirt.org/job/ovirt-system-tests_manual/97/
--
To view, visit https://gerrit.ovirt.org/73455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
9:28 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: rpmlint: silence warning about zero-length conf files
......................................................................
Patch Set 2: Verified+1
ost passed
--
To view, visit https://gerrit.ovirt.org/73455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
11:06 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rpmlint: silence warning about zero-length conf files
......................................................................
rpmlint: silence warning about zero-length conf files
rpmlint does not like empty conf files, so we're shipping them with a
single newline.
Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.sh
M static/etc/vdsm/mom.d/01-parameters.policy
M tests/toolTests_empty.conf
3 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
mooli tayer: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified
--
To view, visit https://gerrit.ovirt.org/73455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b816c39c6453ce667c72eab8d3b310126640dd7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
2646
days inactive
2646
days old
vdsm-patches@lists.fedorahosted.org
4 comments
1 participants
participants (1)
-
Code Review