Change in vdsm[master]: supervdsm: adhere to core_dump_enable

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: supervdsm: adhere to core_dump_enable
......................................................................

supervdsm: adhere to core_dump_enable

Change-Id: Id877e77046dd636c625e5043e358537c07b5beee
Signed-off-by: Dan Kenigsberg 
---
M vdsm/supervdsmServer
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/35480/1

diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 9a447d3..c57870c 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -27,6 +27,7 @@
 import threading
 import re
 import getopt
+import resource
 import signal
 import logging
 import logging.config
@@ -408,6 +409,8 @@
 def main(sockfile, pidfile=None):
     log = logging.getLogger("SuperVdsm.Server")
     zombiereaper.registerSignalHandler()
+    if not config.getboolean('vars', 'core_dump_enable'):
+         resource.setrlimit(resource.RLIMIT_CORE, (0, 0))

def bind(func):
         def wrapper(_SuperVdsm, *args, **kwargs):

Saggi Mizrahi has posted comments on this change.

Change subject: supervdsm: adhere to core_dump_enable
......................................................................

Patch Set 1: Code-Review+2

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: supervdsm: adhere to core_dump_enable
......................................................................

Patch Set 1: Code-Review-1 Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12797/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13749/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13586/ : UNSTABLE

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: supervdsm: adhere to core_dump_enable
......................................................................

Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12799/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13751/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13588/ : SUCCESS

Yeela Kaplan has posted comments on this change.

Change subject: supervdsm: adhere to core_dump_enable
......................................................................

Patch Set 2: Verified+1

Yeela Kaplan has posted comments on this change.

Change subject: supervdsm: adhere to core_dump_enable
......................................................................

Patch Set 2: Verified-1

Change in vdsm[master]: supervdsm: enable coredumping

Yeela Kaplan has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 3: Verified+1

Change in vdsm[master]: supervdsm: enable coredumping

Yeela Kaplan has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 3:

verified both on el6 and el7.
killed process with SIGABRT and coredump was created successfully.

Change in vdsm[master]: supervdsm: enable coredumping

Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 3: Code-Review+1

Change in vdsm[master]: supervdsm: enable coredumping

Dima Kuznetsov has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 3: Code-Review+1

Change in vdsm[master]: supervdsm: enable coredumping

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 3:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13786/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12997/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13949/ : FAILURE

Change in vdsm[master]: supervdsm: enable coredumping

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 3: Code-Review+2

Worth backporting, imho.

Change in vdsm[master]: supervdsm: enable coredumping

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: supervdsm: enable coredumping
......................................................................

supervdsm: enable coredumping

Enable coredump both on el6 (sysvinit)
and on el7 (systemd).
Also, limit core size to 0 in case of
enable_core_dump is set to False

Change-Id: Id877e77046dd636c625e5043e358537c07b5beee
Bug-Url: https://bugzilla.redhat.com/1167814
Signed-off-by: Dan Kenigsberg 
Signed-off-by: Yeela Kaplan 
Reviewed-on: http://gerrit.ovirt.org/35480
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dima Kuznetsov 
---
M init/systemd/supervdsmd.service.in
M init/sysvinit/supervdsmd.init.in
M vdsm/supervdsmServer
3 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Yeela Kaplan: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dima Kuznetsov: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

Change in vdsm[master]: supervdsm: enable coredumping

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: supervdsm: enable coredumping
......................................................................

Patch Set 4:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merg... : ABORTED

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/244/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc20-x86_64_mer... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/461/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el7-x86_64_merg... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/259/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4253/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/266/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/268/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc21-x86_64_mer... : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6091/ : SUCCESS