Dan Kenigsberg has posted comments on this change.
Change subject: Normalize network parameter for VM create flow
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/vm.py
Line 307: self._devices = {'drives': [], 'networks': []}
nics
"networks" are the logical concept configured by Vdsm over host nics. This list
is going to hold guest nics.
Line 379: vhosts[vbridge] = _VHOST_MAP[vstatus.lower()]
I prefer to have this as a local constant
Line 407: nic['sndbufParam'] =
self.conf['custom']['sndbuf']
just like drive["cache"] - i think it should not be stored/reported.
--
To view, visit
http://gerrit.ovirt.org/790
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d064dcdb639a5d98762a153d21de93f43c43254
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>