From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Fix Volume.__init__ signature
......................................................................
pylint: Fix Volume.__init__ signature
Volume.__init__ signature was different from FileVolume and BlockVolume
__init__, making pylint unhappy. The code was correct becuase in runtime
only FileVolume and BlockVolume are created, but pylint could not detect
this.
Simplify the code, moving __init__ from FileVolume and BlockVolume up to
Volume class. This fix these pylint warnings:
E:1010,28: Too many positional arguments for constructor call (too-many-function-args)
E:1018,32: Too many positional arguments for constructor call (too-many-function-args)
This change introduces new pylint errors in fileVolume.py and
blockVolume.py, since VolumeManifest is missing many methods. This will
be fixed in the next patch.
Change-Id: I82f0b081ad57bf5a693d4d956e6e08b880e02ccb
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 2 insertions(+), 10 deletions(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/75798
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82f0b081ad57bf5a693d4d956e6e08b880e02ccb
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>