1:43 p.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Don't use qemu-img to create sparse file volumes
It's not required to run volume.createVolume when we are creating a
sparse file volume (see createSparseFile few lines above).
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
---
M vdsm/storage/fileVolume.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/3626/1
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
10:17 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Don't use qemu-img to create sparse file volumes
It's not required to run volume.createVolume when we are creating a
sparse file volume (see createSparseFile few lines above).
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
---
M vdsm/storage/fileVolume.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
10:17 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
9:30 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
7:42 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
3:40 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 3: Looks good to me, approved
fair enough
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
10:47 p.m.
Mark Wu has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
3:32 p.m.
Igor Lvovsky has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
11:57 p.m.
Mark Wu has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileVolume.py
Line 173
It looks you need remove the comment above together.
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
1:25 p.m.
Igor Lvovsky has posted comments on this change.
Change subject: Don't use qemu-img to create sparse file volumes
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4448
days inactive
4454
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Federico Simoncelli -
Igor Lvovsky -
wudxw＠linux.vnet.ibm.com