Change in vdsm[master]: (Schema) Have discoverSendTargets return parsed objects

Saggi Mizrahi has uploaded a new change for review.

Change subject: (Schema) Have discoverSendTargets return parsed objects
......................................................................

(Schema) Have discoverSendTargets return parsed objects

Change-Id: Ib5b0bba668e3c2532805bef3aefa7cc9302285b0
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 30 insertions(+), 7 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/7149/1

diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index b103b28..581c5ff 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2517,22 +2517,45 @@
  'data': {'address': 'NetworkAddress', '*user': 'str', '*password': 'str'}}

##
+# @IscsiQualifiedName:
+#
+# An iSCSI Qualified Name in RFC 3720 format.
+#     eg. "iqn.1992-01.com.example:storage:diskarrays-sn-a8675309"
+#
+# Since: 4.10.0
+##
+{'alias': 'IscsiQualifiedName', 'data': 'str'}}
+
+#
+# @IscsiTarget:
+#
+# Describes an Iscsi Target.
+#
+# @portal:  The portal which contains the target.
+#
+# @tpgt:    The target portal group tag.
+#
+# @iqn:     The iqn of the target.
+#
+# Since: 4.10.0
+##
+{'type': 'IscsiTarget',
+ 'data': {'portal': 'IscsiPortal',
+          'tpgt': 'uint',
+	  'iqn': 'IscsiQualifiedName'}}
+
+#
 # @ISCSIConnection.discoverSendTargets:
 #
 # Discover available targets for this @ISCSIConnection.
 #
 # Returns:
-# @targets:      A list of discovered target iqns
-#
-# @fullTargets:  A list of discovered targets in the form:
-#                '<host>:<port>,<tpgt> <iqn>'
+# @targets: A list of discovered targets.
 #
 # Since: 4.10.0
-# XXX: The fullTargets strings should be broken out into their respective parts
-# XXX: The return values are in the same dictionary as the command status!
 ##
 {'command': {'class': 'ISCSIConnection', 'name': 'discoverSendTargets'},
- 'returns': {'targets': ['str'], 'fullTargets': ['str']}}
+ 'returns': {'targets': ['IscsiTarget']}}

## Category: @Image ############################################################
 ##

--
To view, visit http://gerrit.ovirt.org/7149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5b0bba668e3c2532805bef3aefa7cc9302285b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: (Schema) Have discoverSendTargets return parsed objects
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/434/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b0bba668e3c2532805bef3aefa7cc9302285b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: (Schema) Have discoverSendTargets return parsed objects
......................................................................

Patch Set 1:

still relevant?

Itamar Heim has abandoned this change.

Change subject: (Schema) Have discoverSendTargets return parsed objects
......................................................................

Abandoned

no reply - abandoning - please restore if still relevant