2 a.m.
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: call sync before umount in mkFloppyFs
......................................................................
call sync before umount in mkFloppyFs
mkFloppyFs creates a floppy image, mount it, write some content, and
umount the image. On some systems, if we umount immediately after writing
content, umount will fail, because the data is not fully synced to disk,
and the device is still busy. This problem causes unit test test_mkFloppyFs
in mkimageTests.py fail.
To avoid the busy device problem, call /usr/bin/sync before umount.
Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M configure.ac
M vdsm/constants.py.in
M vdsm/mkimage.py
M vdsm/storage/misc.py
4 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/6995/1
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
9:38 p.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Zhou Zheng Sheng has abandoned this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5: Abandoned
The bug is actually a gnome bug. On servers we do not install gnome, so it's not worth
to mess up the code to work around a gnome bug.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:26 p.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Dan Kenigsberg has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5: I would prefer that you didn't submit this
Apparently, this is not a kernel bug, but a gnome bug
https://bugzilla.gnome.org/show_bug.cgi?id=677648 . I wish gvfsd-trash could be
configured to leave mounts under /tmp on their own. Until then, please kill this impolite
daemon ;-)
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:03 a.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Mark Wu has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5: No score
Yes, the comment could be inaccurate. But before we find the real root cause, who knows ?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:55 a.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Zhou Zheng Sheng has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5:
It's not related to kernel, so I will update the description in the comments.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:42 a.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Mark Wu has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
It seems not a real kernel bug, but a race caused by gvfs.
I have update my findings on bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=853674
Anyway, I think we should have this workaround because it blocks the test cases running.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:44 a.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Dan Kenigsberg has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
that's an ugly hack for sure ;-)
let us give some more time to figure out if the kernel bug is real.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:01 p.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
oVirt Jenkins CI Server has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/814/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:43 p.m.
New subject: Change in vdsm[master]: wait a little time before umount in mkFloppyFs
Zhou Zheng Sheng has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
......................................................................
Patch Set 5:
Thank Dan for reminding me to check the minimum sleep time. The minimum sleep time to
evade the bug is 0.02s for my machine. To be conservative, use 0.1s in the code.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:58 a.m.
New subject: Change in vdsm[master]: wait 1 second before umount
Dan Kenigsberg has posted comments on this change.
Change subject: wait 1 second before umount
......................................................................
Patch Set 4:
oh, and please confirm that a 0.5 sleep is not enough to evade the bug.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:57 a.m.
New subject: Change in vdsm[master]: wait 1 second before umount
Dan Kenigsberg has posted comments on this change.
Change subject: wait 1 second before umount
......................................................................
Patch Set 4: I would prefer that you didn't submit this
doing this for every umount seems too brutal to me. We only have evidence that it happens
in mkFloppyFs. Please limit the hack to this case (which is much less important, so I do
not mind the latency there).
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:08 a.m.
New subject: Change in vdsm[master]: wait 1 second before umount
oVirt Jenkins CI Server has posted comments on this change.
Change subject: wait 1 second before umount
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/806/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:56 a.m.
New subject: Change in vdsm[master]: wait 1 second before umount
Zhou Zheng Sheng has posted comments on this change.
Change subject: wait 1 second before umount
......................................................................
Patch Set 4: Verified
Run through autobuild.sh, test_mkFloppyFs passed.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:52 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2:
Zhou, could you now add the minimal sleep that works for you, with a big link to the
kernel bz#?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:06 p.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2:
Thanks Dan, the bug is at https://bugzilla.redhat.com/show_bug.cgi?id=853674 . I hope my
little script could be helpful for the kernel developers.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
1:57 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: (1 inline comment)
Please open a kernel bug on this issue, with all the details provided here, and your
simple reproducer.
If we do not get a quick response from kernel guys, we could add a minimalist `sleep(0.1)`
hack. (what's the minimum?)
....................................................
File vdsm/mkimage.py
Line 83: m.mount(mntOpts='loop')
Line 84: try:
Line 85: _decodeFilesIntoDir(files, dirname)
Line 86: # flush changes to disk before we umount
Line 87: # otherwise umount raises "device busy" exception on some
machines
0. gerrit ui re-wraps text paragraphs. To avoid that, add some indentation to a line in
your paragraph. I admit that
https://lists.fedorahosted.org/pipermail/vdsm-patches/2012-August/012152.... is much more
readable... Gerrit ui does not fit very well to long comments as yours..
1. In my opinion,
umount("/home/edward/src/tmpMount", MNT_FORCE) = -1 EBUSY (Device or resource
busy)
is a kernel bug. AFAICT no process is holding open files when this is called. Would you
open a BZ on kernel?
Line 88: storage.misc.syncFileSystem()
Line 89: finally:
Line 90: m.umount(force=True)
Line 91: finally:
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:24 a.m.
ShaoHe Feng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
I also encounter this problem before. but strangely, this problem sometimes come ups, but
it does not come ups for a long time.
it reproduces today.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:33 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2:
Dan, I've tested lazy umounts, it umounts successfully, so mkimage.mkFloppyFs works
well, but test_mkFloppyFs will fail.
test_mkFloppyFs firstly calls mkFloppyFs, and mkFloppyFs mounts a floppy image and write
some files then umount it, then test_mkFloppyFs will mount the image again and check its
contents. If I change the umount in mkFloppyFs to a lazy one, though it works, but when
test_mkFloppyFs mounts again, it sees an empty filesystem so the check fails. I think this
maybe because when umount lazily, the data is still in a kernel buffer waiting to be
flushed to the image. Then we immediately mounts the image and the data is still not
flushed, so we sees an empty filesystem.
I've done another experiment. Firstly, create a new file in the mounted image
filesystem, then write some data, which is the same as what mkFloppyFs does, but before
closing that new file, fsync the file descriptor, then use a lazy umount. Then umount
succeeds and test_mkFloppyFs immediately mounts again and pass the check.
In a word, either fsync + lazy umount or sync + normal umount will work, and just lazy
umount will not pass the contents check. I think this behaviour is very strange. The
kernel is supposed to guarantee the data integrity, but we fail to check the file contents
immediately after a lazy umount, how this can happen? I'm very confused.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:11 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2:
Zhou, I hate to suggest that, but would lazy umount hide the bug?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:40 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/mkimage.py
Line 83: m.mount(mntOpts='loop')
Line 84: try:
Line 85: _decodeFilesIntoDir(files, dirname)
Line 86: # flush changes to disk before we umount
Line 87: # otherwise umount raises "device busy" exception on some
machines
Zhou, which kernel are you using? which libc? could you change mount.py to execute mount
via strace, and capture some debug data from stderr?
Line 88: storage.misc.syncFileSystem()
Line 89: finally:
Line 90: m.umount(force=True)
Line 91: finally:
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
1:58 a.m.
Sandro Bonazzola has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2:
I don't think that the umount failure is due to the writing of the data on the disk. I
think that is something else: if no process is holding a refernce to a file in the mounted
filesystem, umount should block until all data are written to disk. May it be something
related to rhbz #758159 or rhbz #808795 ? Have you some indexing process running on the
systems where the test is failing?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:08 p.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/mkimage.py
Line 87: # otherwise umount raises "device busy" exception on some
machines
I've done some experiment.
1. In _decodeFilesIntoDir, files are opened in a "with" block, so they are
guaranteed to be closed.
2. If I fsync the files then close them, umount still fails.
3. If I let it sleep 2 seconds between _decodeFilesIntoDir and umount, umount works.
4. If I lsof the mount point between _decodeFilesIntoDir and umount, nothing will be
printed, but umount works.
So I guess the driver/kernel holds the devices because the data is in the a kernel buffer
but not written to disk. To get more information on this strange behaviour, I will try to
have a look at my disk cache policy.
By the way, lsof gives the following waring when I lsof the mount point.
lsof: WARNING: can't stat() fuse.gvfs-fuse-daemon file system /run/user/edward/gvfs
Output information may be incomplete
I have fuse and gvfs-fuse packages installed, but fuse.service can not be started. When I
try to start the service, it fails and says "No such file or directory".
I don't know if the fuse problem is related to this problem.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:01 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
thanks, but I'd like to understand the issue a bit better.
....................................................
File vdsm/mkimage.py
Line 87: # otherwise umount raises "device busy" exception on some
machines
could you understand why is the device busy? what is holding it? could you call `lsof`
just before umount to catch them? maybe we should have closed f explicitly in
_decodeFilesIntoDir?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:37 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/30/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:35 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/30/
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:10 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: Verified
patch set 2: add some comments
Run through autobuild.sh and fix the problem for me.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
3:09 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1:
Thanks mark and hejie. After collecting more advice, I will make a new patch set later.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:55 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1:
I have tried lazy umount as well, it does not work. The test case will mount the image
immediately after the previous umount, if I use lazy umount, the check will fail, because
the data is not synced to the image yet. So I have to sync.
By the way, I tried fsync as well. The result is, if I fsync every file and close them,
umount still throws exception. I have to fsync the files and umount lazyli to get it work.
With fsync and a lazy umount, the data is written to the disk before umount, so when the
test case mount again immediately, it checks the contents succesfully.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:48 a.m.
Mark Wu has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1:
I see there's an existing lazy option for the umount() function, so it's easier
to use lazy umount than sync.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:41 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1: (1 inline comment)
Mark Wu, the problem is in the function "mkFloppyFs" in
"vdsm/mkimage.py", not in the test case. The test case just calls
"mkFloppyFs" and fail, so we can know there is a problem. As we write more test
cases, we may reveal the same problem in other vdsm source files, so we may want to call
sync in other files, that's why I add a function.
....................................................
File vdsm/mkimage.py
Line 86: storage.misc.syncFileSystem()
Yes. Otherwise other programmers will get confused.
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:34 a.m.
Mark Wu has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/mkimage.py
Line 86: storage.misc.syncFileSystem()
add a simple comment to explain why it needs a sync here?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:33 a.m.
Mark Wu has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1:
Is it necessary to add a new constant and a function to fix a problem in a test case? How
about just call sync in the test case?
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:18 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 1:
This problem causes unit test "test_mkFloppyFs" in
"tests/mkimageTests.py" fail.
My uname -a is as follow,
Linux zhshzhouf17 3.5.0-2.fc17.x86_64 #1 SMP Mon Jul 30 14:48:59 UTC 2012 x86_64 x86_64
x86_64 GNU/Linux
On my system if I umount immediately after wrting file contents, umount will fail. To
reproduce the problem, you can use the script below. The script mimics what mkFloppyFs
does.
#!/usr/bin/bash
mkdir tmpMount
/usr/sbin/mkfs.msdos -C floppy.img 1440
/usr/bin/mount -o loop floppy.img tmpMount
echo '123'>tmpMount/tst1.txt
echo '123'>tmpMount/tst2.txt
echo '123'>tmpMount/tst3.txt
echo '123'>tmpMount/tst4.txt
echo '123'>tmpMount/tst5.txt
echo '123'>tmpMount/tst6.txt
echo '123'>tmpMount/tst7.txt
echo '123'>tmpMount/tst8.txt
echo '123'>tmpMount/tst9.txt
#sleep 2
/usr/bin/umount -f tmpMount
rm -rf tmpMount floppy.img
When I run the script, umount fails. On some other machine of VM, the script may not
fail.
If I uncomment the "sleep" command in the script, umount works again. This means
some data need to be sync to disk, so the device is busy, and umount can not detach the
devices. On my system, if I sync before umount, umount will work. Some of my colleagues
run into this problem as well.
The patch run through autobuild.sh
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
9:16 p.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
......................................................................
Patch Set 2: (1 inline comment)
@Sandro Bonazzola, thanks for the bugzilla information. I think this bug is not related to
the bugs you pointed out. When those bugs are triggered, the loop device can not be umount
until reboot, but my bug is that if we (sleep 2 seconds | lsof the mount point | sync),
umount will work. So it's a different bug.
....................................................
File vdsm/mkimage.py
Line 83: m.mount(mntOpts='loop')
Line 84: try:
Line 85: _decodeFilesIntoDir(files, dirname)
Line 86: # flush changes to disk before we umount
Line 87: # otherwise umount raises "device busy" exception on some
machines
0. Why some multi-line comments are displayed as one line? In the e-mail the text is
correct, while in the web interface the multi-line comments turn into one line. What's
going on?
1. my kernel version
Linux zhshzhouf17 3.5.1-1.fc17.x86_64 #1 SMP Thu Aug 9 17:50:43 UTC 2012 x86_64 x86_64
x86_64 GNU/Linux
glibc version
glibc-2.15-51.fc17.x86_64
2. I wrote a script to reproduce the problem, this script mimics mkFloppyFs behavior.
#!/usr/bin/bash
mkdir tmpMount
/usr/sbin/mkfs.msdos -C floppy.img 1440
/usr/bin/mount -o loop floppy.img tmpMount
echo '123'>tmpMount/tst1.txt
echo '123'>tmpMount/tst2.txt
echo '123'>tmpMount/tst3.txt
echo '123'>tmpMount/tst4.txt
echo '123'>tmpMount/tst5.txt
echo '123'>tmpMount/tst6.txt
echo '123'>tmpMount/tst7.txt
echo '123'>tmpMount/tst8.txt
echo '123'>tmpMount/tst9.txt
/usr/bin/umount -f tmpMount
rm -rf tmpMount floppy.img
When I run the script, it prints as follow.
# LC_ALL=C ./testumount.sh
mkfs.msdos 3.0.12 (29 Oct 2011)
umount: /home/edward/src/tmpMount: target is busy.
(In some cases useful info about processes that use
the device is found by lsof(8) or fuser(1))
rm: cannot remove `tmpMount': Device or resource busy
When I "lsof +D" the mount point, no one is occupying the directory and files,
but there is a waring says "lsof: WARNING: can't stat() fuse.gvfs-fuse-daemon
file system /run/user/edward/gvfs Output information may be incomplete."
As long as this script fails to umount, mkFloppyFs will fail too.
3. Then I strace the mount and umount in the script, the results are as follow.
----------------- mount.log -----------------
execve("/usr/bin/mount", ["/usr/bin/mount", "-o",
"loop", "floppy.img", "tmpMount"], [/* 52 vars */]) = 0
brk(0) = 0x7fcbe8407000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e56000
access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=135882, ...}) = 0
mmap(NULL, 135882, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fcbe7e34000
close(3) = 0
open("/lib64/libmount.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\220x\0h:\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=183096, ...}) = 0
mmap(NULL, 2275512, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe7a0c000
mprotect(0x7fcbe7a36000, 2097152, PROT_NONE) = 0
mmap(0x7fcbe7c36000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x2a000) = 0x7fcbe7c36000
close(3) = 0
open("/lib64/libblkid.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240j\0F6\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=162496, ...}) = 0
mmap(NULL, 2255080, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe77e5000
mprotect(0x7fcbe7809000, 2093056, PROT_NONE) = 0
mmap(0x7fcbe7a08000, 16384, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x23000) = 0x7fcbe7a08000
close(3) = 0
open("/lib64/libuuid.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3,
"\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320\26\200@6\0\0\0"..., 832)
= 832
fstat(3, {st_mode=S_IFREG|0755, st_size=21696, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e33000
mmap(NULL, 2113960, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe75e0000
mprotect(0x7fcbe75e4000, 2093056, PROT_NONE) = 0
mmap(0x7fcbe77e3000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x3000) = 0x7fcbe77e3000
close(3) = 0
open("/lib64/libselinux.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300_\200:6\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=128888, ...}) = 0
mmap(NULL, 2230304, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe73bf000
mprotect(0x7fcbe73dd000, 2093056, PROT_NONE) = 0
mmap(0x7fcbe75dc000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x1d000) = 0x7fcbe75dc000
mmap(0x7fcbe75de000, 6176, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1,
0) = 0x7fcbe75de000
close(3) = 0
open("/lib64/libsepol.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320@\0\0\0\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=264712, ...}) = 0
mmap(NULL, 2361600, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe717e000
mprotect(0x7fcbe71be000, 2093056, PROT_NONE) = 0
mmap(0x7fcbe73bd000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x3f000) = 0x7fcbe73bd000
close(3) = 0
open("/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@\30\00296\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=2065560, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e32000
mmap(NULL, 3892376, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe6dc7000
mprotect(0x7fcbe6f73000, 2097152, PROT_NONE) = 0
mmap(0x7fcbe7173000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x1ac000) = 0x7fcbe7173000
mmap(0x7fcbe7179000, 17560, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1,
0) = 0x7fcbe7179000
close(3) = 0
open("/lib64/libdl.so.2", O_RDONLY|O_CLOEXEC) = 3
read(3,
"\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240\16\30096\0\0\0"..., 832)
= 832
fstat(3, {st_mode=S_IFREG|0755, st_size=22480, ...}) = 0
mmap(NULL, 2109704, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fcbe6bc3000
mprotect(0x7fcbe6bc6000, 2093056, PROT_NONE) = 0
mmap(0x7fcbe6dc5000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x2000) = 0x7fcbe6dc5000
close(3) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e31000
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e2f000
arch_prctl(ARCH_SET_FS, 0x7fcbe7e2f840) = 0
mprotect(0x7fcbe7173000, 16384, PROT_READ) = 0
mprotect(0x7fcbe6dc5000, 4096, PROT_READ) = 0
mprotect(0x7fcbe75dc000, 4096, PROT_READ) = 0
mprotect(0x7fcbe77e3000, 4096, PROT_READ) = 0
mprotect(0x7fcbe7a08000, 12288, PROT_READ) = 0
mprotect(0x7fcbe7c36000, 4096, PROT_READ) = 0
mprotect(0x7fcbe8062000, 4096, PROT_READ) = 0
mprotect(0x7fcbe7e57000, 4096, PROT_READ) = 0
munmap(0x7fcbe7e34000, 135882) = 0
statfs("/sys/fs/selinux", {f_type=0xf97cff8c, f_bsize=4096, f_blocks=0,
f_bfree=0, f_bavail=0, f_files=0, f_ffree=0, f_fsid={0, 0}, f_namelen=255, f_frsize=4096})
= 0
statfs("/sys/fs/selinux", {f_type=0xf97cff8c, f_bsize=4096, f_blocks=0,
f_bfree=0, f_bavail=0, f_files=0, f_ffree=0, f_fsid={0, 0}, f_namelen=255, f_frsize=4096})
= 0
stat("/sys/fs/selinux", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
brk(0) = 0x7fcbe8407000
brk(0x7fcbe8428000) = 0x7fcbe8428000
getuid() = 0
geteuid() = 0
getuid() = 0
geteuid() = 0
getgid() = 0
getegid() = 0
prctl(PR_GET_DUMPABLE) = 1
lstat("/etc/mtab", {st_mode=S_IFLNK|0777, st_size=12, ...}) = 0
getuid() = 0
geteuid() = 0
getgid() = 0
getegid() = 0
prctl(PR_GET_DUMPABLE) = 1
stat("/run", {st_mode=S_IFDIR|0755, st_size=1580, ...}) = 0
lstat("/run/mount/utab", {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
open("/run/mount/utab", O_RDWR|O_CREAT, 0644) = 3
close(3) = 0
gettid() = 24452
open("/proc/self/task/24452/attr/current", O_RDONLY) = 3
read(3, "unconfined_u:unconfined_r:unconf"..., 4095) = 54
close(3) = 0
getcwd("/home/edward/src", 4095) = 17
readlink("/home/edward/src/floppy.img", 0x7fff37dfd310, 4096) = -1 EINVAL
(Invalid argument)
uname({sys="Linux", node="zhshzhouf17", ...}) = 0
stat("/dev/loop-control", {st_mode=S_IFCHR|0600, st_rdev=makedev(10, 237), ...})
= 0
lstat("/etc/mtab", {st_mode=S_IFLNK|0777, st_size=12, ...}) = 0
open("/proc/self/mountinfo", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e55000
read(3, "15 21 0:3 / /proc rw,nosuid,node"..., 1024) = 1024
read(3, "relatime - cgroup cgroup rw,cpus"..., 1024) = 1024
read(3, "s configfs rw\n38 17 0:12 / /dev/"..., 1024) = 811
read(3, "", 1024) = 0
close(3) = 0
munmap(0x7fcbe7e55000, 4096) = 0
getuid() = 0
geteuid() = 0
getgid() = 0
getegid() = 0
prctl(PR_GET_DUMPABLE) = 1
stat("/run", {st_mode=S_IFDIR|0755, st_size=1580, ...}) = 0
stat("/run/mount/utab", {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
open("/run/mount/utab", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e55000
read(3, "", 4096) = 0
close(3) = 0
munmap(0x7fcbe7e55000, 4096) = 0
getcwd("/home/edward/src", 4095) = 17
readlink("/home/edward/src/tmpMount", 0x7fff37dfd030, 4096) = -1 EINVAL (Invalid
argument)
open("/dev/loop-control", O_RDWR) = 3
ioctl(3, LOOP_CTL_GET_FREE) = 0
close(3) = 0
readlink("/home", 0x7fff37dfd060, 4096) = -1 EINVAL (Invalid argument)
readlink("/home/edward", 0x7fff37dfd060, 4096) = -1 EINVAL (Invalid argument)
readlink("/home/edward/src", 0x7fff37dfd060, 4096) = -1 EINVAL (Invalid
argument)
readlink("/home/edward/src/floppy.img", 0x7fff37dfd060, 4096) = -1 EINVAL
(Invalid argument)
open("/home/edward/src/floppy.img", O_RDWR) = 3
open("/dev/loop0", O_RDWR) = 4
ioctl(4, LOOP_SET_FD, 0x3) = 0
close(3) = 0
ioctl(4, LOOP_SET_STATUS64, {offset=0, number=0, flags=LO_FLAGS_AUTOCLEAR,
file_name="/home/edward/src/floppy.img", ...}) = 0
stat("/dev/loop0", {st_mode=S_IFBLK|0660, st_rdev=makedev(7, 0), ...}) = 0
open("/sys/dev/block/7:0", O_RDONLY) = 3
openat(3, "loop/autoclear", O_RDONLY) = 5
fcntl(5, F_GETFL) = 0x8000 (flags O_RDONLY|O_LARGEFILE)
fstat(5, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e55000
lseek(5, 0, SEEK_CUR) = 0
read(5, "1\n", 4096) = 2
lseek(5, 1, SEEK_SET) = 1
close(5) = 0
munmap(0x7fcbe7e55000, 4096) = 0
openat(3, "ro", O_RDONLY) = 5
fcntl(5, F_GETFL) = 0x8000 (flags O_RDONLY|O_LARGEFILE)
fstat(5, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fcbe7e55000
lseek(5, 0, SEEK_CUR) = 0
read(5, "0\n", 4096) = 2
lseek(5, 1, SEEK_SET) = 1
close(5) = 0
munmap(0x7fcbe7e55000, 4096) = 0
close(3) = 0
access("/dev/loop0", F_OK) = 0
open("/dev/loop0", O_RDONLY) = 3
fadvise64(3, 0, 0, POSIX_FADV_RANDOM) = 0
fstat(3, {st_mode=S_IFBLK|0660, st_rdev=makedev(7, 0), ...}) = 0
uname({sys="Linux", node="zhshzhouf17", ...}) = 0
ioctl(3, BLKGETSIZE64, 1474560) = 0
lseek(3, 0, SEEK_SET) = 0
read(3,
"\353<\220mkdosfs\0\0\2\1\1\0\2\340\0@\v\360\t\0\22\0\2\0\0\0\0\0"..., 1024)
= 1024
lseek(3, 9728, SEEK_SET) = 9728
read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 32)
= 32
lseek(3, 15872, SEEK_SET) = 15872
read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"...,
512) = 512
open("/sys/dev/block/7:0", O_RDONLY) = 5
newfstatat(5, "partition", 0x7fff37dfe0c0, 0) = -1 ENOENT (No such file or
directory)
openat(5, "dm/uuid", O_RDONLY) = -1 ENOENT (No such file or directory)
close(5) = 0
close(3) = 0
stat("/sbin/mount.vfat", 0x7fff37dfe2e0) = -1 ENOENT (No such file or
directory)
stat("/sbin/fs.d/mount.vfat", 0x7fff37dfe2e0) = -1 ENOENT (No such file or
directory)
stat("/sbin/fs/mount.vfat", 0x7fff37dfe2e0) = -1 ENOENT (No such file or
directory)
mount("/dev/loop0", "/home/edward/src/tmpMount", "vfat",
MS_MGC_VAL, NULL) = 0
access("/home/edward/src/tmpMount", W_OK) = 0
close(4) = 0
exit_group(0) = ?
+++ exited with 0 +++
----------------- umount.log -----------------
execve("/usr/bin/umount", ["/usr/bin/umount", "-f",
"tmpMount"], [/* 52 vars */]) = 0
brk(0) = 0x7fc1aba1a000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab668000
access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=135882, ...}) = 0
mmap(NULL, 135882, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fc1ab646000
close(3) = 0
open("/lib64/libmount.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\220x\0h:\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=183096, ...}) = 0
mmap(NULL, 2275512, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1ab21e000
mprotect(0x7fc1ab248000, 2097152, PROT_NONE) = 0
mmap(0x7fc1ab448000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x2a000) = 0x7fc1ab448000
close(3) = 0
open("/lib64/libblkid.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240j\0F6\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=162496, ...}) = 0
mmap(NULL, 2255080, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1aaff7000
mprotect(0x7fc1ab01b000, 2093056, PROT_NONE) = 0
mmap(0x7fc1ab21a000, 16384, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x23000) = 0x7fc1ab21a000
close(3) = 0
open("/lib64/libuuid.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3,
"\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320\26\200@6\0\0\0"..., 832)
= 832
fstat(3, {st_mode=S_IFREG|0755, st_size=21696, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab645000
mmap(NULL, 2113960, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1aadf2000
mprotect(0x7fc1aadf6000, 2093056, PROT_NONE) = 0
mmap(0x7fc1aaff5000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x3000) = 0x7fc1aaff5000
close(3) = 0
open("/lib64/libselinux.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300_\200:6\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=128888, ...}) = 0
mmap(NULL, 2230304, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1aabd1000
mprotect(0x7fc1aabef000, 2093056, PROT_NONE) = 0
mmap(0x7fc1aadee000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x1d000) = 0x7fc1aadee000
mmap(0x7fc1aadf0000, 6176, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1,
0) = 0x7fc1aadf0000
close(3) = 0
open("/lib64/libsepol.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320@\0\0\0\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=264712, ...}) = 0
mmap(NULL, 2361600, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1aa990000
mprotect(0x7fc1aa9d0000, 2093056, PROT_NONE) = 0
mmap(0x7fc1aabcf000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x3f000) = 0x7fc1aabcf000
close(3) = 0
open("/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@\30\00296\0\0\0"...,
832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=2065560, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab644000
mmap(NULL, 3892376, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1aa5d9000
mprotect(0x7fc1aa785000, 2097152, PROT_NONE) = 0
mmap(0x7fc1aa985000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x1ac000) = 0x7fc1aa985000
mmap(0x7fc1aa98b000, 17560, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1,
0) = 0x7fc1aa98b000
close(3) = 0
open("/lib64/libdl.so.2", O_RDONLY|O_CLOEXEC) = 3
read(3,
"\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240\16\30096\0\0\0"..., 832)
= 832
fstat(3, {st_mode=S_IFREG|0755, st_size=22480, ...}) = 0
mmap(NULL, 2109704, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) =
0x7fc1aa3d5000
mprotect(0x7fc1aa3d8000, 2093056, PROT_NONE) = 0
mmap(0x7fc1aa5d7000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3,
0x2000) = 0x7fc1aa5d7000
close(3) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab643000
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab641000
arch_prctl(ARCH_SET_FS, 0x7fc1ab641840) = 0
mprotect(0x7fc1aa985000, 16384, PROT_READ) = 0
mprotect(0x7fc1aa5d7000, 4096, PROT_READ) = 0
mprotect(0x7fc1aadee000, 4096, PROT_READ) = 0
mprotect(0x7fc1aaff5000, 4096, PROT_READ) = 0
mprotect(0x7fc1ab21a000, 12288, PROT_READ) = 0
mprotect(0x7fc1ab448000, 4096, PROT_READ) = 0
mprotect(0x7fc1ab86f000, 4096, PROT_READ) = 0
mprotect(0x7fc1ab669000, 4096, PROT_READ) = 0
munmap(0x7fc1ab646000, 135882) = 0
statfs("/sys/fs/selinux", {f_type=0xf97cff8c, f_bsize=4096, f_blocks=0,
f_bfree=0, f_bavail=0, f_files=0, f_ffree=0, f_fsid={0, 0}, f_namelen=255, f_frsize=4096})
= 0
statfs("/sys/fs/selinux", {f_type=0xf97cff8c, f_bsize=4096, f_blocks=0,
f_bfree=0, f_bavail=0, f_files=0, f_ffree=0, f_fsid={0, 0}, f_namelen=255, f_frsize=4096})
= 0
stat("/sys/fs/selinux", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
brk(0) = 0x7fc1aba1a000
brk(0x7fc1aba3b000) = 0x7fc1aba3b000
getuid() = 0
geteuid() = 0
getuid() = 0
geteuid() = 0
getgid() = 0
getegid() = 0
prctl(PR_GET_DUMPABLE) = 1
lstat("/etc/mtab", {st_mode=S_IFLNK|0777, st_size=12, ...}) = 0
getuid() = 0
geteuid() = 0
getgid() = 0
getegid() = 0
prctl(PR_GET_DUMPABLE) = 1
stat("/run", {st_mode=S_IFDIR|0755, st_size=1580, ...}) = 0
lstat("/run/mount/utab", {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
open("/run/mount/utab", O_RDWR|O_CREAT, 0644) = 3
close(3) = 0
lstat("/etc/mtab", {st_mode=S_IFLNK|0777, st_size=12, ...}) = 0
open("/proc/self/mountinfo", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab667000
read(3, "15 21 0:3 / /proc rw,nosuid,node"..., 1024) = 1024
read(3, "relatime - cgroup cgroup rw,cpus"..., 1024) = 1024
read(3, "s configfs rw\n38 17 0:12 / /dev/"..., 1024) = 969
read(3, "", 1024) = 0
close(3) = 0
munmap(0x7fc1ab667000, 4096) = 0
getuid() = 0
geteuid() = 0
getgid() = 0
getegid() = 0
prctl(PR_GET_DUMPABLE) = 1
stat("/run", {st_mode=S_IFDIR|0755, st_size=1580, ...}) = 0
stat("/run/mount/utab", {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
open("/run/mount/utab", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fc1ab667000
read(3, "", 4096) = 0
close(3) = 0
munmap(0x7fc1ab667000, 4096) = 0
getcwd("/home/edward/src", 4095) = 17
readlink("/home/edward/src/tmpMount", 0x7fffe17fc550, 4096) = -1 EINVAL (Invalid
argument)
stat("/sbin/umount.vfat", 0x7fffe17fd530) = -1 ENOENT (No such file or
directory)
stat("/sbin/fs.d/umount.vfat", 0x7fffe17fd530) = -1 ENOENT (No such file or
directory)
stat("/sbin/fs/umount.vfat", 0x7fffe17fd530) = -1 ENOENT (No such file or
directory)
umount("/home/edward/src/tmpMount", MNT_FORCE) = -1 EBUSY (Device or resource
busy)
write(2, "umount: ", 8umount: ) = 8
write(2, "/home/edward/src/tmpMount: targe"..., 155/home/edward/src/tmpMount:
target is busy.
(In some cases useful info about processes that use
the device is found by lsof(8) or fuser(1))) = 155
write(2, "\n", 1
) = 1
exit_group(32) = ?
+++ exited with 32 +++
In the umount.log, I can not find any useful information.
Line 88: storage.misc.syncFileSystem()
Line 89: finally:
Line 90: m.umount(force=True)
Line 91: finally:
--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sandro.bonazzola(a)gmail.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4280
days inactive
4313
days old
vdsm-patches@lists.fedorahosted.org
33 comments
6 participants
participants (6)
-
Dan Kenigsberg -
Jenkins CI RO -
sandro.bonazzola＠gmail.com -
shaohef＠linux.vnet.ibm.com -
wudxw＠linux.vnet.ibm.com -
zhshzhou＠linux.vnet.ibm.com