11:33 a.m.
Adam Litke has uploaded a new change for review.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
virt: Introduce Vm._setVolumeSize helper
Backport the Vm._setVolumeSize helper for use by LiveMergeCleanupThread
to update the size of the base volume in cases where the top volume was
smaller than the base volume.
Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251958
Signed-off-by: Adam Litke <alitke(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/45106/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index e4f270d..6d8cccb 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5917,6 +5917,14 @@
(domainID, volumeID))
return res['info']
+ def _setVolumeSize(self, domainID, poolID, imageID, volumeID, size):
+ res = self.cif.irs.setVolumeSize(domainID, poolID, imageID, volumeID,
+ size)
+ if res['status']['code'] != 0:
+ raise StorageUnavailableError(
+ "Unable to set volume size to %s for domain %s volume %s" %
+ (size, domainID, volumeID))
+
def _diskXMLGetVolumeChainInfo(self, diskXML, drive):
def find_element_by_name(doc, name):
for child in doc.childNodes:
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
11:34 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 1:
* Update tracker::#1251958::OK
* Check Bug-Url::OK
* Check Public Bug::#1251958::OK, public bug
* Check Product::#1251958::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1251958::OK, correct target release 3.5.5
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
11:37 a.m.
Adam Litke has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
2:05 p.m.
Nir Soffer has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
11:33 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 2:
* Update tracker::#1251958::OK
* Check Bug-Url::OK
* Check Public Bug::#1251958::OK, public bug
* Check Product::#1251958::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1251958::OK, correct target release 3.5.5
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:35 a.m.
Francesco Romani has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 2: Code-Review+1
why not cherry-pick change I742fde77a23387f89fa746c2030e151237cb230f aka patch 37943?
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
11:26 a.m.
Nir Soffer has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 2: Code-Review-1
Please cherry pick the patch from master, keeping the change id and the metadata in the
commit message.
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9:32 a.m.
Adam Litke has abandoned this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Abandoned
Replaced by https://gerrit.ovirt.org/#/c/45949
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9:32 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
......................................................................
Patch Set 2:
* Update tracker::#1251958::OK
--
To view, visit https://gerrit.ovirt.org/45106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3190
days inactive
3211
days old
vdsm-patches@lists.fedorahosted.org
8 comments
4 participants
participants (4)
-
alitke＠redhat.com -
automation＠ovirt.org -
fromani＠redhat.com -
Nir Soffer