Change in vdsm[master]: Excluding some VM commands on migration

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Excluding some VM commands on migration
......................................................................

Excluding some VM commands on migration

Some operations are not permitted during a live migration:

* take a live snapshot
* hotplug/hotunplug a disk device

Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
---
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 19 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/1389/1
--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Excluding some VM commands on migration
......................................................................


Patch Set 2: Verified; Looks good to me, approved

‎The protection introduced in this patch is obviously raceful, but it is a step forward.

Please acquire self._guestCpuLock when you do one of these mutually-exclusive operations!

--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Excluding some VM commands on migration
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Excluding some VM commands on migration
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 306:         self._taskLock = threading.Lock()
When are you using this?

--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Excluding some VM commands on migration
......................................................................


Patch Set 1: (1 inline comment)

It looks like I'll need to wait for this patch before my hotplug NIC, because I'll
need to add same handling as you added in hotplug disk.

....................................................
File vdsm/define.py
Line 49:             'migInProgress':{'status': {'code':49,
'message': 'Command not supported during migration'}},
Ah, I already use 49 and 50 in my hotplugNic.
One of us will need to change it (depends of push order of course)  :)

--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Excluding some VM commands on migration
......................................................................


Excluding some VM commands on migration

Some operations are not permitted during a live migration:

* take a live snapshot
* hotplug/hotunplug a disk device

Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
---
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 18 insertions(+), 3 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Excluding some VM commands on migration
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/vm.py
Line 306:         self._taskLock = threading.Lock()
Argh, leftovers. Thanks.

--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;