Federico Simoncelli has posted comments on this change.
Change subject: task: update the message when running jobs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26773/2/vdsm/storage/task.py
File vdsm/storage/task.py:
Line 904: raise se.TaskAborted("shutting down")
Line 905: self.log.debug("Task.run: running job %s: %s" % (i,
j))
Line 906: self._updateResult(
Line 907: 0, 'running job {0} of {0}'.format(i + 1,
len(self.jobs)),
Line 908: '')
My only concern is: on some parts of the codebase we're actively
getting ri
I understood the opposite... we're not enforcing format() (not
downvoting the old style).
Line 909: result = self._run(j.run)
Line 910: if result is None:
Line 911: result = ""
Line 912: i += 1
--
To view, visit
http://gerrit.ovirt.org/26773
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14983c3cf0a394e01173c31e676bebb14041fcd2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes