Francesco Romani has posted comments on this change.
Change subject: virt: Initial support for post-copy migration ......................................................................
Patch Set 12: Code-Review+1
(1 comment)
we just need the packages.
https://gerrit.ovirt.org/#/c/62873/12/vdsm/virt/migration.py File vdsm/virt/migration.py:
PS12, Line 485: # Migration may fail immediately when VIR_MIGRATE_POSTCOPY is : # present in the following situations: : # - The transport is not capable of full bidirectional : # connectivity: RDMA, tunnelled, pipe. : # - Huge pages are used (doesn't apply to transparent huge pages). : # - QEMU uses a file as a backing for memory. : # - Perhaps non-shared block storage may cause some trouble. : if self._use_convergence_schedule and \ : not self._tunneled: : for s in self._convergence_schedule.get('stalling', []): : action = s.get('action', {}).get('name') : if action == CONVERGENCE_SCHEDULE_POST_COPY: : flags |= libvirt.VIR_MIGRATE_POSTCOPY : break it would be nice to factor this code in a method, because I want to refactor all the flags selection code in a not so distant feature.
It's just a "nice to have", however, so I'm not pushing for thiss
vdsm-patches@lists.fedorahosted.org