Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#567077 task.py: avoid overtly silly casting to str() ......................................................................
BZ#567077 task.py: avoid overtly silly casting to str()
For a reason unknown (to me), task.py does not use pickle to persist its data to file. We cannot fix that without breaking backward-compatibility. However, we can avoid pointless casts to str, and can encode data to utf8 before storing to disk.
Change-Id: I97db724db436e99b95c3524e70fab540f7191334 --- M vdsm/storage/task.py 1 file changed, 48 insertions(+), 50 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/1622/1 -- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#567077 task.py: avoid overtly silly casting to str() ......................................................................
Patch Set 1:
note that this patch should go further testing - I did only minimal stuff.
-- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ#567077 task.py: avoid overtly silly casting to str() ......................................................................
Patch Set 1: Fails
-- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Haim Ateya has posted comments on this change.
Change subject: task.py: avoid overtly silly casting to str() ......................................................................
Patch Set 3: Verified
Dan - patch is good enough as it doesn't introduce new regressions, however, it doesn't handle certain cases of uni-code processing.
-- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Eduardo has posted comments on this change.
Change subject: task.py: avoid overtly silly casting to str() ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
Under pressure
-- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: task.py: avoid overtly silly casting to str() ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: task.py: avoid overtly silly casting to str() ......................................................................
task.py: avoid overtly silly casting to str()
For a reason unknown (to me), task.py does not use pickle to persist its data to file. We cannot fix that without breaking backward-compatibility. However, we can avoid pointless casts to str, and can encode data to utf8 before storing to disk.
Note that this patch does not solve BZ#567077 as the storage subsystem prevents entry of Unicode arguments. This prevention must be kept for old storage domain formats.
Change-Id: I97db724db436e99b95c3524e70fab540f7191334 --- M vdsm/storage/task.py 1 file changed, 48 insertions(+), 50 deletions(-)
Approvals: Haim Ateya: Verified Eduardo: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1622 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
vdsm-patches@lists.fedorahosted.org