Arik Hadas has posted comments on this change.
Change subject: keep pauseCode when migrating paused VM
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/27801/3//COMMIT_MSG
Commit Message:
Line 6:
Line 7: keep pauseCode when migrating paused VM
Line 8:
Line 9: This patch fix a bug where the pauseCode is cleared on the destination
Line 10: host when migrating paused VM.
There is a bug for this? Please add a bug-url if so; if there
isn't, please
well.. the answer is "yes. but.." :) it is related to bz
1053884, but not exactly and this patch is not required for the solution for that bug.
I'll add few lines here as you suggested
Line 11:
Line 12: Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036
http://gerrit.ovirt.org/#/c/27801/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1952: self._ongoingCreations.release()
Line 1953: self.log.debug("_ongoingCreations released")
Line 1954:
Line 1955: migrating = 'migrationDest' in self.conf or \
Line 1956: 'restoreState' in self.conf
This cries for a cleanup/refactoring, but of course this has to be
done in
+1
we should also consider line 1960 - I don't understand why we set it always to UP,
what if the status on the source host was paused? we set it to up and it is switched right
after that to paused when we get the status from libvirt? maybe we can set it to the
status the VM had on the source host
Line 1957: if migrating and self.lastStatus != vmstatus.DOWN:
Line 1958: self._waitForIncomingMigrationFinish()
Line 1959:
Line 1960: self.lastStatus = vmstatus.UP
--
To view, visit
http://gerrit.ovirt.org/27801
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes