Change in vdsm[ovirt-4.0]: virt: Don't crash in migration progress on compression bytes

Hello Francesco Romani, Michal Skrivanek,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/64499

to review the following change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

virt: Don't crash in migration progress on compression bytes

If compression is not enabled for a migration then compression stats are
not provided by libvirt.  So when we try to retrieve them in migration
Progress, we must not expect their presence, otherwise we crash there.

Backport-To: 4.0
Change-Id: I1885940843d705ead161c13258f1979025a03873
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/64468
Reviewed-by: Michal Skrivanek 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M vdsm/virt/migration.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/64499/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 8f2af23..e502756 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -769,7 +769,7 @@
             stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING],
             stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],
             stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT],
-            stats[libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES],
+            stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0),
             # available since libvirt 1.3
             stats.get('memory_dirty_rate', -1),
             # available since libvirt 1.3

gerrit-hooks has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 1: Verified-1

* update_tracker: OK

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK,         change not open on any previous branch

Francesco Romani has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 1: Code-Review+1

We'll need a bug; we can piggyback on an existing one (granted it is somehow related) or file a new one.

Michal Skrivanek has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 1: Code-Review+1

gerrit-hooks has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 2:

* #64468::Update tracker: OK
* #1380822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1380822::OK, public bug
* Check Product::#1380822::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TM::#1380822::ERROR, wrong target milestone for stable branch, --- should match ^.*4.0.*
* Check merged to previous::OK,         change not open on any previous branch

Milan Zamazal has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 2: Verified+1

Bug number added.

Verified that with this change the crash (KeyError) is no longer present and that a VM can be successfully migrated even with compression disabled.

Francesco Romani has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 2: Code-Review+2

Francesco Romani has submitted this change and it was merged.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

virt: Don't crash in migration progress on compression bytes

If compression is not enabled for a migration then compression stats are
not provided by libvirt.  So when we try to retrieve them in migration
Progress, we must not expect their presence, otherwise we crash there.

Backport-To: 4.0
Bug-Url: https://bugzilla.redhat.com/1380822
Change-Id: I1885940843d705ead161c13258f1979025a03873
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/64468
Reviewed-by: Michal Skrivanek 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/64499
---
M vdsm/virt/migration.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified

gerrit-hooks has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
......................................................................

Patch Set 3:

* #64468::Update tracker: OK
* #1380822::Update tracker: OK
* #64499::Update tracker: OK
* Set MODIFIED::bug 1380822::::#1380822::::IGNORE, not all related patches are closed, check 65007