Change in vdsm[master]: Remove redundant supervsdm.validateAccess.

Eduardo has uploaded a new change for review.

Change subject: Remove redundant supervsdm.validateAccess.
......................................................................

Remove redundant supervsdm.validateAccess.

Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
---
M vdsm/storage/fileSD.py
M vdsm/supervdsmServer
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/20838/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index f9ff93b..47c5448 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -35,7 +35,6 @@
 from persistentDict import PersistentDict, DictValidator
 from vdsm import constants
 from vdsm.utils import stripNewLines
-import supervdsm
 import mount
 
 REMOTE_PATH = "REMOTE_PATH"
@@ -50,10 +49,6 @@
 def validateDirAccess(dirPath):
     try:
         getProcPool().fileUtils.validateAccess(dirPath)
-        supervdsm.getProxy().validateAccess(
-            constants.QEMU_PROCESS_USER,
-            (constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath,
-            (os.R_OK | os.X_OK))
     except OSError as e:
         if e.errno == errno.EACCES:
             raise se.StorageServerAccessPermissionError(dirPath)
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index d42e320..7a9c3da 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -57,7 +57,6 @@
 from storage.iscsi import readSessionInfo as _readSessionInfo
 from supervdsm import _SuperVdsmManager
 from storage.fileUtils import chown, resolveGid, resolveUid
-from storage.fileUtils import validateAccess as _validateAccess
 from vdsm.constants import METADATA_GROUP, EXT_UDEVADM, \
     DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS, VDSM_USER
 from storage.devicemapper import _removeMapping, _getPathsStatus
@@ -237,11 +236,6 @@
             raise err
 
         return res
-
-    @logDecorator
-    def validateAccess(self, user, groups, *args, **kwargs):
-        return self._runAs(user, groups, _validateAccess, args=args,
-                           kwargs=kwargs)
 
     @logDecorator
     def setSafeNetworkConfig(self):


-- 
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove redundant supervsdm.validateAccess.
......................................................................


Patch Set 1: Code-Review-1

sorry, I leaded you wrong. you should not remove the verb from supervdsm , and actually
use it

what you are trying to validate is if you have access as qemu process, which runs as qemu
user. if you use oop for that, you actually check access for vdsm user... validateAccess
in supervdsm let you check access for any user you want

-- 
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Saggi Mizrahi has posted comments on this change.

Change subject: Remove redundant supervsdm.validateAccess.
......................................................................


Patch Set 1: Code-Review-1

You are reverting, why?

commit e9caf1f1f98b226a984a4f126a20440835cc7bad
Author: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Date:   Mon Aug 1 14:56:03 2011 +0300

    BZ#726105 - Check that qemu can also access file mounts
    
    v3:
    - use both qemu and kvm groups when testing access to directory
    v4:
    - add OOP handling. I hate NFS.

-- 
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove redundant supervsdm.validateAccess.
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant supervsdm.validateAccess.
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4400/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5204/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5280/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Eduardo has abandoned this change.

Change subject: Remove redundant supervsdm.validateAccess.
......................................................................


Abandoned

We need to unify this functions anyway.

-- 
To view, visit http://gerrit.ovirt.org/20838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server