2:27 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing libvirt configure print
......................................................................
Changing libvirt configure print
Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/17296/1
diff --git a/lib/vdsm/tool/libvirt_configure.sh.in
b/lib/vdsm/tool/libvirt_configure.sh.in
index be043d4..845e856 100755
--- a/lib/vdsm/tool/libvirt_configure.sh.in
+++ b/lib/vdsm/tool/libvirt_configure.sh.in
@@ -279,7 +279,7 @@
case "$1" in
reconfigure)
- echo "Starting configure libvirt to VDSM ..."
+ echo "Starting configure libvirt for VDSM..."
configure "$LCONF" "$QCONF" "$LDCONF"
"$QLCONF" "$2"
echo "=Done configuring libvirt="
RETVAL=$?
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
2:52 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2687/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3494/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3578/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:43 a.m.
Greg Padgett has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:52 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2730/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3537/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3621/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:08 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:11 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 280: case "$1" in
Line 281: reconfigure)
Line 282: echo "Configuring libvirt for vdsm"
Line 283: configure "$LCONF" "$QCONF" "$LDCONF"
"$QLCONF" "$2"
Line 284: echo "Done configuring"
I do not like this line at all (also the original one). On most cases, where libvirt is
already configured we see
Configuring libvirt for vdsm
Done configuring
libvirt is already configured for vdsm
which confuses me every time since it was introduced.
Line 285: RETVAL=$?
Line 286: ;;
Line 287: test_conflict_configurations)
Line 288: echo "Checking conflicts ..."
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:17 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2762/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3569/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3653/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:20 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:26 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Changing libvirt configure print
......................................................................
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
1:41 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Changing libvirt configure print
......................................................................
Changing libvirt configure print
Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17296
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3938
days inactive
3944
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
Dan Kenigsberg -
gpadgett＠redhat.com -
Jenkins CI RO -
ybronhei＠redhat.com