Martin Polednik has posted comments on this change.
Change subject: vdsm: isolate fake_kvm into a hook
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46897/2/vdsm.spec.in
File vdsm.spec.in:
Line 408: %description hook-fakearch
Line 409: VDSM hook that intercepts capabilities returned by VDSM to allow faking the
Line 410: target architecture.
Line 411: To enable this hook on your host, set vars.fake_kvm_support=true and target
Line 412: architecture in vars.fake_kvm_architecture in your /etc/vdsm/vdsm.conf.
not sure this hook should be configured using the main vdsm.conf.
for backwards compatibility, I'd keep it in [vars] (at least for the current
version) - good point though!
Line 413:
Line 414: %package hook-fakevmstats
Line 415: Summary: Generate random VM statistics
Line 416: Requires: %{name}
--
To view, visit
https://gerrit.ovirt.org/46897
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes