8:11 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: fix typo in the numa hook summary
......................................................................
spec: fix typo in the numa hook summary
Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/10436/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 2be6592..7e992ef 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -315,7 +315,7 @@
this hook will expose it to the guests.
%package hook-numa
-Summary: numa sopport for VDSM
+Summary: NUMA support for VDSM
BuildArch: noarch
%description hook-numa
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9:29 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:28 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/512/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/547/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:27 a.m.
Maor Lipchuk has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:42 a.m.
Maor Lipchuk has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm.spec.in
Line 318: Summary: NUMA support for VDSM
Line 319: BuildArch: noarch
Line 320:
Line 321: %description hook-numa
Line 322: Hooks is getting number/rage of numa nodes and numa mode,
Not sure it is relevant for this patch but isn't numa should be upper case also here?
Line 323: and update the VM xml.
Line 324:
Line 325: %package hook-pincpu
Line 326: Summary: Hook pin VM so specific CPUs
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:11 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/524/ (2/2)
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:14 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/489/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/524/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:11 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/489/ (1/2)
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:46 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: fix typo in the numa hook summary
......................................................................
spec: fix typo in the numa hook summary
Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Federico Simoncelli: Verified; Looks good to me, approved
Dan Kenigsberg:
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/547/ (2/2)
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/512/ (1/2)
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:50 p.m.
Vered Volansky has posted comments on this change.
Change subject: spec: fix typo in the numa hook summary
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eee4df9db645af51e75661f382b123b2df6919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4157
days inactive
4163
days old
vdsm-patches@lists.fedorahosted.org
11 comments
5 participants
participants (5)
-
Dan Kenigsberg -
Federico Simoncelli -
Jenkins CI RO -
Maor Lipchuk -
vvolansk＠redhat.com