Eduardo has uploaded a new change for review.
Change subject: Adding optional startupPolicy for (file) cdrom and floppy. ......................................................................
Adding optional startupPolicy for (file) cdrom and floppy.
Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/1277/1 -- To view, visit http://gerrit.ovirt.org/1277 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Adding optional startupPolicy for (file) cdrom and floppy. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1277 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Eduardo has posted comments on this change.
Change subject: Adding optional startupPolicy for (file) cdrom and floppy. ......................................................................
Patch Set 2: Verified
Manually tested
-- To view, visit http://gerrit.ovirt.org/1277 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding optional startupPolicy for (file) cdrom and floppy. ......................................................................
Adding optional startupPolicy for (file) cdrom and floppy.
Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Eduardo: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1277 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Adding optional startupPolicy for (file) cdrom and floppy. ......................................................................
Patch Set 2: Looks good to me, approved
yep, that's our former behvior.
-- To view, visit http://gerrit.ovirt.org/1277 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic919158eede6667a6e9105ada0d970f507f0271d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org