Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Create the java bindings and fix bugs
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
+1 only for json python part! I'll recheck on new ps
....................................................
File lib/yajsonrpc/betterAsyncore.py
Line 221: self.ac_in_buffer = ''
Line 222:
Line 223: def _find_prefix_at_end(haystack, needle):
Line 224: l = len(needle) - 1
Line 225: while l and not haystack.endswith(needle[:l]):
while l>0
Line 226: l -= 1
Line 227: return l
Line 228:
Line 229: def handle_write(self, dispatcher):
--
To view, visit
http://gerrit.ovirt.org/19497
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes