Federico Simoncelli has posted comments on this change.
Change subject: [WIP] Update the rpm pre scriptlet
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm.spec.in
Line 62: %clean
Line 63: %{__rm} -rf %{buildroot}
Line 64:
Line 65: %pre
Line 66: /usr/sbin/useradd -r -u 36 -g kvm -d /var/lib/vdsm \
We don't need to relay on a raceful test, useradd fails if the user is already
present:
useradd: user 'vdsm' already exists
The majority of daemons try to set the home to a /var directory (if they own one) to be
extra-safe about not polluting the root.
Line 67: -s /sbin/nologin -c "Node Virtualization Manager"
vdsm
Line 68: /usr/sbin/usermod -a -G qemu vdsm
Line 69:
Line 70: %post
--
To view, visit
http://gerrit.usersys.redhat.com/911
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>