[NEW PATCH] Update the rpm pre scriptlet (via gerrit-bot)

[Federico Simoncelli]

New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/911

commit b3f9679f6866a091e3f65a406a73a0ca9121db2d
Author: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Date:   Wed Sep 7 12:12:57 2011 +0000

    Update the rpm pre scriptlet
    
    Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af

diff --git a/vdsm.spec.in b/vdsm.spec.in
index f1a3473..d2a7411 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -63,8 +63,9 @@ make check
 %{__rm} -rf %{buildroot}
 
 %pre
-getent passwd vdsm > /dev/null || /usr/sbin/useradd -u 36 -g kvm -o -r vdsm -c
"RHEV node manager" -d / -s /sbin/nologin
-/usr/sbin/usermod -a -G qemu vdsm
+useradd -r -u 36 -g kvm -d /var/lib/vdsm \
+        -s /sbin/nologin -c "Node Virtualization Manager" vdsm
+usermod -a -G qemu vdsm
 
 %post
 tmp_sudoers=$(mktemp)

Change in vdsm[master]: [WIP] Update the rpm pre scriptlet

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Update the rpm pre scriptlet
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 62: %clean
Line 63: %{__rm} -rf %{buildroot}
Line 64: 
Line 65: %pre
Line 66: /usr/sbin/useradd -r -u 36 -g kvm -d /var/lib/vdsm \
is it polite to override existing user?

why /var/lib/vdsm ?
Line 67:                   -s /sbin/nologin -c "Node Virtualization Manager"
vdsm
Line 68: /usr/sbin/usermod -a -G qemu vdsm
Line 69: 
Line 70: %post


--
To view, visit http://gerrit.usersys.redhat.com/911
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: [WIP] Update the rpm pre scriptlet

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: [WIP] Update the rpm pre scriptlet
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm.spec.in
Line 62: %clean
Line 63: %{__rm} -rf %{buildroot}
Line 64: 
Line 65: %pre
Line 66: /usr/sbin/useradd -r -u 36 -g kvm -d /var/lib/vdsm \
We don't need to relay on a raceful test, useradd fails if the user is already
present:

 useradd: user 'vdsm' already exists

The majority of daemons try to set the home to a /var directory (if they own one) to be
extra-safe about not polluting the root.
Line 67:                   -s /sbin/nologin -c "Node Virtualization Manager"
vdsm
Line 68: /usr/sbin/usermod -a -G qemu vdsm
Line 69: 
Line 70: %post


--
To view, visit http://gerrit.usersys.redhat.com/911
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: [WIP] Update the rpm pre scriptlet

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: [WIP] Update the rpm pre scriptlet
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm.spec.in
Line 63: %clean
Line 64: %{__rm} -rf %{buildroot}
Line 65: 
Line 66: %pre
Line 67: getent passwd vdsm >/dev/null || \
I agree on the use of getent only because this way we don't need to hide the output
for useradd (which could fail for other reasons... not that anyone will ever notice it at
the right time).
Line 68:     useradd -r -u 36 -g kvm -d /var/lib/vdsm \
Line 69:             -s /sbin/nologin -c "Node Virtualization Manager" vdsm
Line 70: usermod -a -G qemu vdsm
Line 71: 


--
To view, visit http://gerrit.usersys.redhat.com/911
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: [WIP] Update the rpm pre scriptlet

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Update the rpm pre scriptlet
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/911
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Update the RPM pre-scriptlet

[Federico Simoncelli]

Federico Simoncelli has abandoned this change.

Change subject: Update the RPM pre-scriptlet
......................................................................


Patch Set 5: Abandoned

Now included in change 1023:

http://gerrit.usersys.redhat.com/1023

--
To view, visit http://gerrit.usersys.redhat.com/911
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8effe06b95b008eafff63a75a16f0518788bd9af
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;