Change in vdsm[master]: netconf: Make default rollback nullify runningConfig

Antoni Segura Puimedon has uploaded a new change for review.

Change subject: netconf: Make default rollback nullify runningConfig
......................................................................

netconf: Make default rollback nullify runningConfig

It should be possible for a unified configurator to perform
several transactions. In order to do this, it is responsibility
of the rollback method to nullify the running configuration it
had, since any modification there was to it will be rolled back
by the system as part of the leftovers.

Change-Id: Ia7d6503db2a3911d7cb5f429adf2b2022d6c5c2b
Signed-off-by: Antoni S. Puimedon 
---
M vdsm/netconf/__init__.py
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/22337/1

diff --git a/vdsm/netconf/__init__.py b/vdsm/netconf/__init__.py
index 7c6fe2a..bc1abe5 100644
--- a/vdsm/netconf/__init__.py
+++ b/vdsm/netconf/__init__.py
@@ -66,7 +66,9 @@
         """
         # self.runningConfig will have all the changes that were applied before
         # we needed to rollback.
-        return RunningConfig().diffFrom(self.runningConfig)
+        leftover = RunningConfig().diffFrom(self.runningConfig)
+        self.runningConfig = None
+        return leftover

def configureBridge(self, bridge, **opts):
         raise NotImplementedError

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netconf: Make default rollback nullify runningConfig
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6055/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1019/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5268/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6158/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netconf: Make default rollback nullify runningConfig
......................................................................

Patch Set 1: Code-Review-1

Antoni Segura Puimedon has abandoned this change.

Change subject: netconf: Make default rollback nullify runningConfig
......................................................................

Abandoned