From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-06-26 11:22:07 +0200
Line 4: Commit: Andrej Krejcir <akrejcir(a)redhat.com>
Line 5: CommitDate: 2017-07-11 15:54:35 +0200
Line 6:
Line 7: RPC: Refactor ClientRpcTransportAdapter
if you call it "Refactor" - why not also to move this code out of stompreactor
and have all client code in one module.common code between server to client can be maybe
in this module/. what do you think?
Line 8:
Line 9: The class now subscribes in the constructor,
Line 10: instead of taking an existing subscription
Line 11: as a parameter.
--
To view, visit
https://gerrit.ovirt.org/78655
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes