Martin Polednik has posted comments on this change.
Change subject: configs: move sudoers to static
......................................................................
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/61603/5/static/Makefile.am
File static/Makefile.am:
PS5, Line 58: mv
why mv and not cp?
Because we're renaming the file.
PS5, Line 60: chmod
Agreed on the install; unsure about the dir: it is created somewhere
in the
After discussing further with vfeenstra, in this case install and mkdir are
*wrong*. The directory is created by autotools as it is one of dir suffixed variables, and
install is supposed to be used to copy file from one location to other, this is a rename.
--
To view, visit
https://gerrit.ovirt.org/61603
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd006ff4fdafbe436974f868e461c105ae0dba1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes