8:16 a.m.
Dan Kenigsberg has uploaded a new change for review.
Change subject: connectivity log: report dropped devices
......................................................................
connectivity log: report dropped devices
When a networking device is removed from the host it (and its most
recently recorded state) is logged to connectivity.log
Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Bug-Url: https://bugzilla.redhat.com/1111234
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/30227/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 26d670a..e2bed5d 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -300,6 +300,10 @@
else:
text += 'new %s:(%s) ' % (ifid, sample.to_connlog())
+ for ifid, sample in other.interfaces.iteritems():
+ if ifid not in self.interfaces:
+ text += 'dropped %s:(%s) ' % (ifid, sample.to_connlog())
+
if self.recentClient != other.recentClient:
text += 'recent_client:%s' % self.recentClient
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
8:24 a.m.
Francesco Romani has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8:29 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10308/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11093/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1327/ : There was an
infra issue, please contact infra(a)ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11250/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:19 a.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:43 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 1: Verified+1
log shows
dropped ddddddddd:(operstate:down speed:0 duplex:unknown)
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:50 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10321/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11106/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1333/ : There was an
infra issue, please contact infra(a)ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11263/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:52 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10323/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11108/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1335/ : There was an
infra issue, please contact infra(a)ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11265/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:05 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:05 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: connectivity log: report dropped devices
......................................................................
connectivity log: report dropped devices
When a networking device is removed from the host it (and its most
recently recorded state) is logged to connectivity.log
Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Bug-Url: https://bugzilla.redhat.com/1111234
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/30227
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
7:16 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: connectivity log: report dropped devices
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5632/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3790/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1650/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/30227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb6b661efa12a7e7f3456caf23b15ea5c73ca5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3571
days inactive
3575
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
asegurap＠redhat.com -
Dan Kenigsberg -
fromani＠redhat.com -
Jenkins CI RO