Nir Soffer has uploaded a new change for review.
Change subject: sp: pep8 1.6.2 fix ......................................................................
sp: pep8 1.6.2 fix
Both pep8 tool and me do not like line breaks before binary operators.
Change-Id: Ic8e561da219c31aa26d32dcb615eacf223050f5c Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm/storage/sp.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/65050/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index b4b1731..dabe892 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -316,8 +316,8 @@ # mailbox and the "self._setSecure() call"
# FIXME : Use a system wide grouping mechanism - if (self.lvExtendPolicy == "ON" - and self.masterDomain.supportsMailbox): + if (self.lvExtendPolicy == "ON" and + self.masterDomain.supportsMailbox): self.masterDomain.prepareMailbox() self.spmMailer = storage_mailbox.SPM_MailMonitor(self, maxHostID)
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 1: Verified+1
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Freddy Rolland has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 8: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 9: Code-Review+2
Nir Soffer has submitted this change and it was merged.
Change subject: sp: pep8 1.6.2 fix ......................................................................
sp: pep8 1.6.2 fix
Both pep8 tool and me do not like line breaks before binary operators.
Change-Id: Ic8e561da219c31aa26d32dcb615eacf223050f5c Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65050 Reviewed-by: Freddy Rolland frolland@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke alitke@redhat.com --- M vdsm/storage/sp.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org