Adam Litke has uploaded a new change for review.
Change subject: fix remove: iterate while del ......................................................................
fix remove: iterate while del
Change-Id: I594c98cf54ed93d045b76df1c6faa5122277b19e Signed-off-by: Adam Litke alitke@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/44572/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 74bf82d..832fb8b 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -201,8 +201,8 @@ vols = _getVolsTree(sdUUID)
# Remove volumes awaiting garbage collection from the result - for vol_id in vols.iterkeys(): - if vols[vol_id].garbage_meta_id is not None: + for vol_id, vol_info in vols.items(): + if vol_info.garbage_meta_id is not None: del vols[vol_id]
res = {}
automation@ovirt.org has posted comments on this change.
Change subject: fix remove: iterate while del ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Jenkins CI RO has abandoned this change.
Change subject: fix remove: iterate while del ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
gerrit-hooks has posted comments on this change.
Change subject: fix remove: iterate while del ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org