Dan Kenigsberg has uploaded a new change for review.
Change subject: Use drive[path] only after it is known ......................................................................
Use drive[path] only after it is known
Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/1066/1 -- To view, visit http://gerrit.ovirt.org/1066 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Use drive[path] only after it is known ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1066 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Use drive[path] only after it is known ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1066 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Use drive[path] only after it is known ......................................................................
Patch Set 2: Verified
verified by
(03:12:42 PM) xTs_w: those two changes work for me
-- To view, visit http://gerrit.ovirt.org/1066 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Use drive[path] only after it is known ......................................................................
Use drive[path] only after it is known
... and make isBlockDevice actually work. Thanks, xTs_w!
Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 --- M vdsm/utils.py M vdsm/vm.py 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Dan Kenigsberg: Verified Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1066 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org