Change in vdsm[master]: fixed iscsi discovery and added iSER transport support

[Roi Dayan]

Roi Dayan has uploaded a new change for review.

Change subject: fixed iscsi discovery and added iSER transport support
......................................................................

fixed iscsi discovery and added iSER transport support

Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
---
M vdsm/config.py.in
M vdsm/storage/iscsi.py
2 files changed, 41 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1350/1
--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fixed iscsi discovery and added iSER transport support
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Thanks for your patch, however, please review my former comments.

I'd be happy if the default would be to completely avoid changing the transport.

And I really need an iscsiadm bug for the transport issue.

....................................................
File vdsm/config.py.in
Line 216:         ('iscsi_transports', 'tcp', None ),
documentation instead of "None" is recommended

....................................................
File vdsm/storage/iscsi.py
Line 39: SENDTARGETS_DISCOVERY = [constants.EXT_ISCSIADM, "-m",
"discoverydb", "-t", "sendtargets", "-o",
"new", "-o", "delete"]
it does not seem that you've addressed my comments in
http://gerrit.ovirt.org/#patch,sidebyside,905,1,vdsm/storage/iscsi.py

Please do.

Also, consider rebasing over http://gerrit.ovirt.org/#change,1249

--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: fixed iscsi discovery and added iSER transport support
......................................................................


Patch Set 1: Do not submit

This is all should be addressed by the Iscsi Refactoring
http://gerrit.ovirt.org/#change,1607

With the new code you should just be able to use iser as the iface name.

--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Roi Dayan]

Roi Dayan has abandoned this change.

Change subject: fixed iscsi discovery and added iSER transport support
......................................................................


Patch Set 1: Abandoned

there is a different patch

--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;