Mark Wu has uploaded a new change for review.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Fix "unknown device" issue for balloon device
The balloon device's 'alias' property should be updated in function _getUnderlyingBalloonDeviceInfo(), otherwise it will be recognized as a unknown device in _getUnderlyingUnknownDeviceInfo().
For the 'model' property, it must be included in the balloon device parameter and libvirt will not change it, so we needn't get back from libvirt.
For the 'address' property, libvirt may change it on confict addresses. So change to always update 'address' from libvirt as the way we handle drives and network interfaces.
Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/3901/1 -- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 1:
Igor, I am going to send a patch to enable balloon device by default. That means it will make use of the balloon device created by libvirt, and not disable it by adding a 'none' type balloon device. I think it's harmless even though ballooning is not supported on engine side. It will not cause any break or overhead. If this idea is acceptable, I am going to abandon this patch, because the problematic code will be removed. Vdsm client needn't add balloon device in vm's conf since it's already enabled by default. What's your opinion? Thanks!
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Igor Lvovsky has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 1: (1 inline comment)
I am not sure about changing the default behavior. I can't see any reason to do it, in opposite it will just waste PCI slot for nothing.
.................................................... File vdsm/libvirtvm.py Line 2206: dev['alias'] = alias In generally all above is right. I used 'if address' only for case that we have more than one balloon device. In theory it can be a case, but very rare on practice.
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2206: dev['alias'] = alias I think the vdsm client needn't care about the pci address even two balloon devices are configured, because libvirt can assign address to each device properly even with address conflicting in devices parameters. So I change to always update 'address' from libvirt as the way we handle drives and network interfaces. How do you think of it?
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Igor Lvovsky has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2206: dev['alias'] = alias You are right, libvirt will assign proper addresses to each balloon device. but we still need to keep right values in our internal parameters. Now in your patch in case of several balloons you will just overwrite all devices with same address.
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2206: dev['alias'] = alias Yes, that's a problem. I just assumed only one balloon device configured for one VM. I have fixed it in patch v2. Thanks!
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Igor Lvovsky has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
I answered to your question in patchset 1, so can found out there my opinion about default behavior of balloon
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 2: Looks good to me, approved
Mark, would you formally state that this has been tested?
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Patch Set 2: Verified
Without this fix, the balloon device is recognized as an unknown device when it parse underlying information: two balloon entries are seen in vm'conf: {'device': 'memballoon', 'specParams': {'model': 'virtio'}, 'type': 'balloon', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}}, and {'device': '', 'alias': 'balloon0', 'type': 'memballoon', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}}
With this fix, the balloon entry in vm's conf is updated well: {'device': 'memballoon', 'specParams': {'model': 'virtio'}, 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'type': 'balloon', 'alias': 'balloon0'}
So change it to verified.
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix "unknown device" issue for balloon device ......................................................................
Fix "unknown device" issue for balloon device
The balloon device's 'alias' property should be updated in function _getUnderlyingBalloonDeviceInfo(), otherwise it will be recognized as a unknown device in _getUnderlyingUnknownDeviceInfo().
For the 'model' property, it must be included in the balloon device parameter and libvirt will not change it, so we needn't get back from libvirt.
Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org