Change in vdsm[master]: BZ#844347 - Prepare conf files for all interfaces before ifu...

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
......................................................................

BZ#844347 - Prepare conf files for all interfaces before ifup

Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 21 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/6826/1
--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

more of a question than a true -1.

....................................................
File vdsm/configNetwork.py
Line 1096:         if bridge:
why do we need to take the bridge device down? are we changing it in any way or form here?

--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
......................................................................

BZ#844347 - Prepare conf files for all interfaces before ifup

Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Signed-off-by: Igor Lvovsky 
---
M vdsm/configNetwork.py
1 file changed, 22 insertions(+), 6 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified

--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ec769e371e01eed240d806d1343661cbe574ca5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer